From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mCziNdO/hWWewScAWB0awg (envelope-from ) for ; Fri, 22 Dec 2023 11:56:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703264211; bh=+NQQvkibUCAARggPwwd5IdNSMCD0+GzU9YPTEyEzql4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wPp3dI3hzXhrcj9gFGHAOiGZdr1vKUcAv7j31mG0PdfzED/vLl7xfMVnRs1Ug+8Hz I6uxMf1wYRERtzu+i1F43XmAWXdG7tx+YgZN8xXNjSTRhNnMbtwY7xrM3fKDEkjjRq dDlFGpTSEbX8+MyzPc6Ly/ESvk081EuBKiTNBnys= Received: by simark.ca (Postfix, from userid 112) id D9C9D1E0C3; Fri, 22 Dec 2023 11:56:51 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=wHe7fKiT; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB8CF1E0AC for ; Fri, 22 Dec 2023 11:56:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 890423858C29 for ; Fri, 22 Dec 2023 16:56:49 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 961C23858C2F for ; Fri, 22 Dec 2023 16:56:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 961C23858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 961C23858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703264191; cv=none; b=PbfV2q9cmO5fQB6w4UB+dytraTSLGswemDu93m15XPkk0QG57ud/EglV1CeL0RP8GEm56/jLwh2bLNO7VFVR58RTGk9lYBeby/xS6fmXT0/VoWO4Hh5RFsH3vwvf1b+rBOV5LVfHNeV8HoJJayjTFva3zpyAA0ZtPkfYulx7Jkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703264191; c=relaxed/simple; bh=+NQQvkibUCAARggPwwd5IdNSMCD0+GzU9YPTEyEzql4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RUOZwFmVPYAYsZhjtiYrrnmhJwl8+Xzfc1yz0nm6ZOWb0SOVtI9YxBalIA/Be8JOZxOY+1qvKqZKr9ARPTQYI2k4bqSCyn6Jnk3sTjc9xQF6nceT+MBx9bvR4ga0d6l8zTDvY7A1Nhfd/LXjad22wf4YGl/JBi+UyFbaowiyyrc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703264190; bh=+NQQvkibUCAARggPwwd5IdNSMCD0+GzU9YPTEyEzql4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wHe7fKiTAnp2kHaNScLDEXEc4aRw4s4iw9sIZ8kLUSZNYu0UDPC3Pe7rjHpQpO3Fo 7jwx0KC2ddZqGXnQCVDr3q56itViw0xbsFMKR2CuF6OAk+h72S27ZOFJ7Xegb3SLod +u+RZ/RrddLK4sh00BHCVphrPVze/hopG1P9vMzk= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D84EA1E0AC; Fri, 22 Dec 2023 11:56:29 -0500 (EST) Message-ID: <443a741e-661e-42ea-96a5-62911ccc6a63@simark.ca> Date: Fri, 22 Dec 2023 11:56:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id Content-Language: en-US To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20231221191716.257256-1-simon.marchi@efficios.com> <20231221191716.257256-8-simon.marchi@efficios.com> <87frzu18qr.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87frzu18qr.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2023-12-22 11:51, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Remove VALUE_NEXT_FRAME_ID, replace it with a method on struct value. Set > Simon> `m_location.reg.next_frame_id` directly from value::allocate_register_lazy, > Simon> which is fine because allocate_register_lazy is a static creation > Simon> function for struct value. > > I looks like every user except value::fetch_lazy_register actually > immediatley calls find_frame_by_id with the result; so I wonder if this > should just return a frame_info_ptr instead. I'm not sure I understand, which function do you think should return a frame_info_ptr? Simon