From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6994 invoked by alias); 5 Apr 2006 10:05:25 -0000 Received: (qmail 6985 invoked by uid 22791); 5 Apr 2006 10:05:24 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Apr 2006 10:05:23 +0000 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-03.spheriq.net with ESMTP id k35A5Kq2026561 for ; Wed, 5 Apr 2006 10:05:20 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-03.spheriq.net with ESMTP id k35A5DM6022925 for ; Wed, 5 Apr 2006 10:05:19 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id k35A5DMX014453 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Wed, 5 Apr 2006 10:05:13 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 77951DA41; Wed, 5 Apr 2006 10:05:12 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E0933473B2; Wed, 5 Apr 2006 10:04:50 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHK64900 (AUTH stubbsa); Wed, 5 Apr 2006 11:05:08 +0100 (BST) Message-ID: <443395C0.6040709@st.com> Date: Wed, 05 Apr 2006 10:05:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Michael Snyder Cc: GDB Patches Subject: Re: [PATCH] allow nested sourced commands References: <442BD6F1.8070804@st.com> <44324959.4@st.com> <44324B1E.3070409@st.com> <4432CFC1.4090308@redhat.com> In-Reply-To: <4432CFC1.4090308@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.01 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00054.txt.bz2 Michael Snyder wrote: > Well, it has the virtue of simplicity! > At first glance, it seems conceptually valid. > > I think you need a clean-up, though. What if it errors? Look again, more closely :) arg_cleanup IS a clean-up. Does that mean it is OK? Thanks for the quick review Andrew