Re: [PATCH v1] gdb: align siginfo_t with the Linux kernel definition

[Matthieu Longo <matthieu.longo@arm.com>]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On 24/06/2026 22:45, Thiago Jung Bauermann wrote:
> Hello Matthieu,
> 
> Sorry for the delay in responding.
> 
> Matthieu Longo <matthieu.longo@arm.com> writes:
>>> --- a/gdb/linux-tdep.c
>>> +++ b/gdb/linux-tdep.c
>>> @@ -293,6 +293,13 @@ linux_get_siginfo_type (struct gdbarch *gdbarch)
>>>     struct type *uint32_type = builtin_types->builtin_uint32;
>>>     void_ptr_type = lookup_pointer_type (builtin_type (gdbarch)->builtin_void);
>>> +  /* Compute padding length, i.e. __ADDR_BND_PKEY_PAD.  */
>>> +  unsigned alignof_void_ptr = type_align (void_ptr_type);
>>> +  unsigned padding_size = (alignof_void_ptr < sizeof(short)
>>> +                          ? sizeof(short)
>>> +                          : alignof_void_ptr);
> 
> Nit: the two lines above are indented with spaces rather than tabs.

I don't understand why those lines should be using spaces instead of tabs.
See the attached screenshots.
You can see that the style I used is similar to existing ones in aarch64-linux-tdep.c or elsewhere.
Please can you clarify what you meant.

Matthieu

[-- Attachment #2: Screenshot 2026-06-25 102635.png --]
[-- Type: image/png, Size: 18125 bytes --]

[-- Attachment #3: Screenshot 2026-06-25 102328.png --]
[-- Type: image/png, Size: 28638 bytes --]