Daniel Jacobowitz wrote:
>> I haven't actually tested it, but shouldn't gdbtk_readline() and 
>> gdbtk_query() return values? In particular, gdbtk_query() should return 
>> 1 (yes) as the default answer, just as query() does in utils.c.
> 
> You're right; my patch won't work.  How about this one instead?  Make
> input_from_terminal_p do something sensible for Insight.

I'm a little confused now. I assume you meant to retain the cli-script.c
and top.h patches from your previous posting, but, even so, your patch
doesn't even attempt to tackle the problems with query() and
read_command_lines().

I think you are getting at the attached patch. I have tested this and it 
does what I want it to. It produces no extra failures in the test suite.

I'm still a little concerned that input_from_terminal_p no longer seems
to take 'caution' into account. Is that deliberate?

Andrew Stubbs