From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69250 invoked by alias); 12 Feb 2020 14:12:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69239 invoked by uid 89); 12 Feb 2020 14:12:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 14:12:28 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 44EE51E827; Wed, 12 Feb 2020 09:12:26 -0500 (EST) Subject: Re: [PATCH] rust/25535 Apply embedded offset to enum variant calculation To: Tom Tromey Cc: Doug Evans , gdb-patches@sourceware.org, ibobyr@google.com References: <000000000000fb79ae059e568398@google.com> <8bed0bb2-50ae-07ac-5176-8d7e1fc443c8@simark.ca> <871rr0b5pv.fsf@tromey.com> From: Simon Marchi Message-ID: <44294377-8ee1-fe8d-e1b1-0c4e6f50d176@simark.ca> Date: Wed, 12 Feb 2020 14:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <871rr0b5pv.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00451.txt.bz2 On 2020-02-12 2:54 a.m., Tom Tromey wrote: >>> gdb/ChangeLog >>> PR rust/25535 >>> * rust-lang.c (rust_print_enum): Apply embedded_offset to >>> rust_enum_variant calculation. >>> >>> gdb/testsuite/ChangeLog >>> PR rust/25535 >>> * gdb.rust/simple.exp: Add test. >>> * gdb.rust/simple.rs: Add test. > > Simon> Hi Doug, > > Simon> Tom has this big series that gets rid of the val_print API (and therefore embedded_offset), > Simon> which I think was on its way in. See this patch here in particular: > > Simon> https://sourceware.org/ml/gdb-patches/2019-12/msg00288.html > > Simon> Could you check if that fixes the bug? Of course, the test you add would still be relevant. > > I think it's fine to land this now. > > I'll try to rebase the val_print thing soon. I've kind of been breaking > things a lot so I've been putting it off a little. Agreed, we don't lose anything by merging this now. Simon