From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24235 invoked by alias); 27 Mar 2006 11:32:31 -0000 Received: (qmail 24221 invoked by uid 22791); 27 Mar 2006 11:32:30 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 27 Mar 2006 11:32:29 +0000 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-03.spheriq.net with ESMTP id k2RBWPDN021637 for ; Mon, 27 Mar 2006 11:32:25 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-03.spheriq.net with ESMTP id k2RBWPYl030998 for ; Mon, 27 Mar 2006 11:32:25 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id k2RBWLM5027953 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Mon, 27 Mar 2006 11:32:24 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A93DBDA42; Mon, 27 Mar 2006 11:32:15 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9B18C47405; Mon, 27 Mar 2006 11:36:13 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHJ94597 (AUTH stubbsa); Mon, 27 Mar 2006 12:32:12 +0100 (BST) Message-ID: <4427CCAC.3030800@st.com> Date: Mon, 27 Mar 2006 19:57:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Andrew STUBBS , Mark Kettenis , gdb-patches@sourceware.org, insight@sourceware.org Subject: Re: [PATCH] Don't call Insight hooks when not appropriate References: <44104BB2.6000108@st.com> <200603091910.k29JAucq014442@elgar.sibelius.xs4all.nl> <20060309191304.GA31165@nevyn.them.org> <44115FE2.4070206@st.com> <20060325000428.GH26748@nevyn.them.org> In-Reply-To: <20060325000428.GH26748@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.01 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00308.txt.bz2 Daniel Jacobowitz wrote: >> How would you like it done? > > Does something like this work? Fixes a nasty cleanups bug in user > commands at the same time. I haven't actually tested it, but shouldn't gdbtk_readline() and gdbtk_query() return values? In particular, gdbtk_query() should return 1 (yes) as the default answer, just as query() does in utils.c. Andrew