From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id CD6F7384A022 for ; Thu, 13 Aug 2020 12:58:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CD6F7384A022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42c.google.com with SMTP id l2so5186473wrc.7 for ; Thu, 13 Aug 2020 05:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HE9faHjACD5YIkqcGsGs0NpdI6wbLCq8x4XGvbryUwE=; b=PQHk4hUDKk0WvwYIQhMXGzRAA84taQJhCpTay71Humx32emzpnyDqZ8OSR8FyuijVu MFK1KoQuFRSnsb7G/QFiEO4rWyBY0b7DEPPh2u0SnLbK+tUJA8OyaxdmWInuh2B8bfJg aeit9yXFX3gObfPSc2uafGTNhkCsDqTTl4ZssCSCCg/08CpHEzYtvYwrXjZUg1DTe8EP sQDwiaETsbzXBsXG5c3bDq0MzzRN22VB1Ho05DjCF0tTei4sjBiMilwkYooHKWKVXIqe B7UzpCB84tj4LMx9VQfK5X2dH58g6TMyrz2jzIBaXULdVNw3Asw+DthNi1ApUBHwkwVE lrsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HE9faHjACD5YIkqcGsGs0NpdI6wbLCq8x4XGvbryUwE=; b=gHe88IF51uZmiKoY2lvBkraEXsQBSbp2xOsglbY5rKL9gWeZ9rwgOqYTQ5f33wNXvM jyj23ugt4p99zsCp6/FisfIR3Utp4IymdAgf3cJbr/e9tdK3x37jrPTs63YssDnmQoSv HC+VDUm/zHnmG/znGPDx+Qg3zFXJL5+tFC18ReGXqHs3zwvdg+XjCzZgScjVHhcHYzk7 9BFIeHi4fz6Tp4t9vKpP6AOZDjCJX01YIGSsCUvdKChVJ7CMjVg1OR6JbYnkdpAPiYWV spBZf2RFolvUtd/Fti+haiI490ekmteCDcKc0CZR+cn4rOq647qISNauU+WbWwjF/UuH S06g== X-Gm-Message-State: AOAM532/W/xFNdDGFp1BX8kctPJck3E03Vglip9C3/2x2Pxs4bgfspJF 9YQjSrMak4UzR0E8gj9Db1uVXzDVCCw= X-Google-Smtp-Source: ABdhPJwBiVpNnkJ3FMFelwr47Fu//7rZ0BZYXSoixq9ltqzgFB0dwFwpEO1oL+5rm7J/ko556CJbpQ== X-Received: by 2002:adf:e6cc:: with SMTP id y12mr3895599wrm.391.1597323533764; Thu, 13 Aug 2020 05:58:53 -0700 (PDT) Received: from localhost (host86-186-80-213.range86-186.btcentralplus.com. [86.186.80.213]) by smtp.gmail.com with ESMTPSA id g14sm9426882wme.16.2020.08.13.05.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 05:58:53 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 2/8] gdbsupport: Make function arguments constant in enum-flags.h Date: Thu, 13 Aug 2020 13:58:39 +0100 Message-Id: <44267df2ec496c918c09467d28770f366de15ba5.1597319264.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 12:58:56 -0000 Make the arguments used for the operators within enum-flags.h constant references where possible. There should be no user visible changes after this commit. gdbsupport/ChangeLog: * enum-flags.h (enum_flags) : Make arguments const. : Likewise. : Likewise. : Likewise. : Likewise. : Likewise. : Likewise. (operator&): Likewise. (operator|): Likewise. (operator^): Likewise. (operator~): Likewise. --- gdbsupport/ChangeLog | 14 ++++++++++++++ gdbsupport/enum-flags.h | 20 ++++++++++---------- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/gdbsupport/enum-flags.h b/gdbsupport/enum-flags.h index 78db3c7d88e..356eb7da785 100644 --- a/gdbsupport/enum-flags.h +++ b/gdbsupport/enum-flags.h @@ -129,17 +129,17 @@ class enum_flags : m_enum_value ((enum_type) 0) {} - enum_flags &operator&= (enum_type e) + enum_flags &operator&= (const enum_type &e) { m_enum_value = (enum_type) (underlying_value () & e); return *this; } - enum_flags &operator|= (enum_type e) + enum_flags &operator|= (const enum_type &e) { m_enum_value = (enum_type) (underlying_value () | e); return *this; } - enum_flags &operator^= (enum_type e) + enum_flags &operator^= (const enum_type &e) { m_enum_value = (enum_type) (underlying_value () ^ e); return *this; @@ -150,15 +150,15 @@ class enum_flags return m_enum_value; } - enum_flags operator& (enum_type e) const + enum_flags operator& (const enum_type &e) const { return (enum_type) (underlying_value () & e); } - enum_flags operator| (enum_type e) const + enum_flags operator| (const enum_type &e) const { return (enum_type) (underlying_value () | e); } - enum_flags operator^ (enum_type e) const + enum_flags operator^ (const enum_type &e) const { return (enum_type) (underlying_value () ^ e); } @@ -183,28 +183,28 @@ class enum_flags template typename enum_flags_type::type -operator& (enum_type e1, enum_type e2) +operator& (const enum_type &e1, const enum_type &e2) { return enum_flags (e1) & e2; } template typename enum_flags_type::type -operator| (enum_type e1, enum_type e2) +operator| (const enum_type &e1, const enum_type &e2) { return enum_flags (e1) | e2; } template typename enum_flags_type::type -operator^ (enum_type e1, enum_type e2) +operator^ (const enum_type &e1, const enum_type &e2) { return enum_flags (e1) ^ e2; } template typename enum_flags_type::type -operator~ (enum_type e) +operator~ (const enum_type &e) { return ~enum_flags (e); } -- 2.25.4