From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3866 invoked by alias); 15 Mar 2006 19:48:21 -0000 Received: (qmail 3857 invoked by uid 22791); 15 Mar 2006 19:48:21 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Mar 2006 19:48:20 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k2FJmH45023480; Wed, 15 Mar 2006 14:48:17 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k2FJmG111179; Wed, 15 Mar 2006 14:48:17 -0500 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k2FJmFhg021621; Wed, 15 Mar 2006 14:48:15 -0500 Message-ID: <44186F79.3090704@redhat.com> Date: Wed, 15 Mar 2006 22:28:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sourceware.org Subject: Re: [commit] Clean up proc-service includes in gdbserver References: <20060315161633.GA15527@nevyn.them.org> In-Reply-To: <20060315161633.GA15527@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00200.txt.bz2 Daniel Jacobowitz wrote: > A while ago, I posted MIPS and ARM NPTL support for gdbserver. > Before I got around to checking it in, Mark K. looked at one of > them and went "ewwww..."; it was just copied from three other places > in gdbserver, but I totally agree with his reaction. So this patch > un-ewwws things a bit. Instead of borrowing gdb_proc_service.h > from gdb, this patch gives gdbserver its own, slightly different > copy. > > We don't use the prfpregset_t functions at all, so we can lose some > old autoconf checks, too. > > Tested and committed. > If gdb_proc_service.h is shared between gdb and gdbserver, should we move it up to ../include/gdb?