From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3334 invoked by alias); 15 Mar 2006 19:46:02 -0000 Received: (qmail 3322 invoked by uid 22791); 15 Mar 2006 19:46:00 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Mar 2006 19:45:59 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k2FJjuob022856; Wed, 15 Mar 2006 14:45:56 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k2FJjt110638; Wed, 15 Mar 2006 14:45:56 -0500 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k2FJjshg021568; Wed, 15 Mar 2006 14:45:54 -0500 Message-ID: <44186EF1.8070603@redhat.com> Date: Wed, 15 Mar 2006 19:51:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sourceware.org Subject: Re: RFC: Correct "paddr_t" in gdb_proc_service.h References: <20060315163650.GA16226@nevyn.them.org> In-Reply-To: <20060315163650.GA16226@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00199.txt.bz2 Daniel Jacobowitz wrote: > If there is no , GDB will typedef unsigned long to paddr_t, > which is then used in various libthread_db interfaces. Even when this code > was designed to work on Solaris systems in addition to GNU/Linux, this > wasn't right; Solaris doesn't provide a paddr_t that has anything to do with > libthread_db, only an unrelated one that deals with physical addressing. > The type that glibc's libthread_db uses is psaddr_t, which is a pointer > type. > > When I wrote this patch (last year) I went through the original changelog > entries for this file from 2000; they suggest that this change is correct > and there should be no paddr_t references in GDB. > > I admit that I can't rememeber now what problem this solved; it may be > nothing, just an inconsistency I noticed while working on N32 support. But I > think it's a worthwhile change to match the prototypes in libthread_db from > whence these functions are called. > > Any comments on this change? > Seems ok -- except the cast for target_read_memory should be (CORE_ADDR) addr, n'est ce pas?