From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29219 invoked by alias); 10 Mar 2006 11:18:23 -0000 Received: (qmail 29203 invoked by uid 22791); 10 Mar 2006 11:18:23 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-04.spheriq.net (HELO fra-del-04.spheriq.net) (195.46.51.100) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Mar 2006 11:18:22 +0000 Received: from fra-out-01.spheriq.net (fra-out-01.spheriq.net [195.46.51.129]) by fra-del-04.spheriq.net with ESMTP id k2ABIGQK006278 for ; Fri, 10 Mar 2006 11:18:17 GMT Received: from fra-cus-01.spheriq.net (fra-cus-01.spheriq.net [195.46.51.37]) by fra-out-01.spheriq.net with ESMTP id k2ABIEmN013737 for ; Fri, 10 Mar 2006 11:18:14 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-01.spheriq.net with ESMTP id k2ABIBdn008263 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 10 Mar 2006 11:18:12 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4AFFCDA46; Fri, 10 Mar 2006 11:18:11 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 951C1473E4; Fri, 10 Mar 2006 11:22:01 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHI59651 (AUTH stubbsa); Fri, 10 Mar 2006 11:18:09 GMT Message-ID: <44115FE2.4070206@st.com> Date: Fri, 10 Mar 2006 19:16:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Mark Kettenis , andrew.stubbs@st.com, gdb-patches@sourceware.org, insight@sourceware.org Subject: Re: [PATCH] Don't call Insight hooks when not appropriate References: <44104BB2.6000108@st.com> <200603091910.k29JAucq014442@elgar.sibelius.xs4all.nl> <20060309191304.GA31165@nevyn.them.org> In-Reply-To: <20060309191304.GA31165@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.01 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00159.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Mar 09, 2006 at 08:10:56PM +0100, Mark Kettenis wrote: >>> Date: Thu, 09 Mar 2006 15:37:22 +0000 >>> From: Andrew STUBBS >>> >>> 2006-03-09 Andrew Stubbs >>> >>> * cli/cli-script.c (execute_user_command): Set instream to -1, not 0. >>> (read_command_lines): Check instream before calling the prompt hook. >> I think this usage of -1 is a bad idea. > > Me too. We're already using a global variable; why not just add > another and restore it in the same cleanup? I don't really mind, as long as it works. How would you like it done? Andrew