From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27941 invoked by alias); 10 Mar 2006 00:19:33 -0000 Received: (qmail 27923 invoked by uid 22791); 10 Mar 2006 00:19:32 -0000 X-Spam-Check-By: sourceware.org Received: from ip127.bb146.pacific.net.hk (HELO mailhub.stlglobal.com) (202.64.146.127) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Mar 2006 00:19:29 +0000 Received: from localhost ([127.0.0.1]) by mailhub.stlglobal.com with esmtp (Exim 4.50) id 1FHVLZ-0002Pm-Rl; Fri, 10 Mar 2006 08:19:10 +0800 Message-ID: <4410C609.5090207@tausq.org> Date: Fri, 10 Mar 2006 01:35:00 -0000 From: Randolph Chung User-Agent: Debian Thunderbird 1.0.2 (X11/20051002) MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sources.redhat.com, dave@hiauly1.hia.nrc.ca Subject: Re: [hpux] Fix build problem on hpux References: <44104BCC.8060700@tausq.org> <200603091908.k29J8E67001447@elgar.sibelius.xs4all.nl> In-Reply-To: <200603091908.k29J8E67001447@elgar.sibelius.xs4all.nl> Content-Type: multipart/mixed; boundary="------------010802050009050305000605" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00151.txt.bz2 This is a multi-part message in MIME format. --------------010802050009050305000605 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 327 > This can't be right. The point is to add -D_XOPEN_SOURCE_EXTENDED > whenever we compile *on* HP-UX, not whenever we're targeting HP-UX. > This should be handled using autoconf, much in the same way as we do > for _GNU_SOURCE, since it affects the functionality made available by > the OS. How about this instead? randolph --------------010802050009050305000605 Content-Type: text/x-patch; name="hpcomp.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="hpcomp.diff" Content-length: 2536 2005-03-09 Randolph Chung * hpread.c (hpread_start_psymtab): Remove hpread_psymtab_to_symtab declaration. * acinclude.m4 (gdb_AC_HPUX): Define. * config.in (_XOPEN_SOURCE_EXTENDED): Define if needed. * configure.ac: Call gdb_AC_HPUX. * configure: Regenerate. Index: hpread.c =================================================================== RCS file: /cvs/src/src/gdb/hpread.c,v retrieving revision 1.58 diff -u -p -r1.58 hpread.c --- hpread.c 17 Dec 2005 22:34:01 -0000 1.58 +++ hpread.c 9 Mar 2006 15:28:16 -0000 @@ -2385,7 +2386,6 @@ hpread_start_psymtab (struct objfile *ob struct partial_symbol **static_syms) { int offset = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); - extern void hpread_psymtab_to_symtab (); struct partial_symtab *result = start_psymtab_common (objfile, objfile->section_offsets, filename, textlow, global_syms, static_syms); Index: acinclude.m4 =================================================================== RCS file: /cvs/src/src/gdb/acinclude.m4,v retrieving revision 1.13 diff -u -p -r1.13 acinclude.m4 --- acinclude.m4 17 Dec 2005 22:33:59 -0000 1.13 +++ acinclude.m4 10 Mar 2006 00:16:44 -0000 @@ -987,3 +987,14 @@ if test x = y ; then fi ]) +AC_DEFUN(gdb_AC_HPUX, +[AC_BEFORE([$0], [AC_TRY_COMPILE])dnl +AC_BEFORE([$0], [AC_TRY_RUN])dnl +AC_MSG_CHECKING(for HPUX) +AC_EGREP_CPP(yes, +[#ifdef _HPUX_SOURCE + yes +#endif +], [AC_MSG_RESULT(yes); AC_DEFINE(_XOPEN_SOURCE_EXTENDED)], AC_MSG_RESULT(no)) +]) + Index: config.in =================================================================== RCS file: /cvs/src/src/gdb/config.in,v retrieving revision 1.82 diff -u -p -r1.82 config.in --- config.in 3 Jul 2005 16:05:11 -0000 1.82 +++ config.in 10 Mar 2006 00:16:44 -0000 @@ -607,6 +607,13 @@ # undef _ALL_SOURCE #endif +/* Define to 1 if on HPUX. + System headers sometimes define this. + We just want to avoid a redefinition error message. */ +#ifndef _XOPEN_SOURCE_EXTENDED +# undef _XOPEN_SOURCE_EXTENDED +#endif + /* Enable GNU extensions on systems that have them. */ #ifndef _GNU_SOURCE # undef _GNU_SOURCE Index: configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.30 diff -u -p -r1.30 configure.ac --- configure.ac 21 Feb 2006 21:02:25 -0000 1.30 +++ configure.ac 10 Mar 2006 00:18:27 -0000 @@ -30,6 +30,7 @@ AM_MAINTAINER_MODE AC_PROG_CC AC_GNU_SOURCE AC_AIX +gdb_AC_HPUX AC_ISC_POSIX AM_PROG_CC_STDC --------------010802050009050305000605--