From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23501 invoked by alias); 1 Mar 2006 21:39:36 -0000 Received: (qmail 23492 invoked by uid 22791); 1 Mar 2006 21:39:36 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Mar 2006 21:39:31 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k21LdQxP015751; Wed, 1 Mar 2006 16:39:26 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k21LdP110713; Wed, 1 Mar 2006 16:39:25 -0500 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k21LdOKt021421; Wed, 1 Mar 2006 16:39:24 -0500 Message-ID: <4406148B.20207@redhat.com> Date: Wed, 01 Mar 2006 21:39:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sourceware.org Subject: Re: RFC: Initialize libthread_db at the right time References: <20060227194414.GA26229@nevyn.them.org> In-Reply-To: <20060227194414.GA26229@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00020.txt.bz2 Daniel Jacobowitz wrote: > We've had some recurring problems debugging statically linked executables > using libthread_db; this patch is the first of several fixes for that. > This doesn't do much; it just splits the check out from the new_objfile > hook, and calls it from target_post_attach and target_post_startup_inferior > in the Linux native target. > > Earlier versions of this patch used an observer instead, which was silly > of me; we only want to do this when we're sitting on top of the Linux > native target, not when we're on top of e.g. the remote target. This > mostly fixes the not-enabling-libthread_db-when-we-should-be class of > problems; there's still one gross hack in remote.c which avoids > calling the new objfile hook for remote targets, but that's a mess > for another day. > > Any comments? Otherwise, I'll commit this in a few days. It handles > LinuxThreads, but NPTL needs a little push (coming up next). I don't promise that I understand it completely, but I don't see anything glaringly wrong with it. Michael