From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3aePNu+ZgGB3RAAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 17:32:31 -0400 Received: by simark.ca (Postfix, from userid 112) id D06CF1F104; Wed, 21 Apr 2021 17:32:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 10B011E789 for ; Wed, 21 Apr 2021 17:32:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34437384605A; Wed, 21 Apr 2021 21:32:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34437384605A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619040750; bh=I3OkLvtAuSqQrASxIQE2AbBNy10SNapn4zZkuJ4+4/s=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=J5Fw3gNSDBI4fUXVOsFPg399cNZlnMqe4M3zCAMQrbU8CQ3Dt03+sJsgzNW6pKxCb QBYtiDhT50knPsW87V8y4IfAwq1phqWHfxrYGLoXcNsIFRgvhj44Zf7kbApbQp2CZn 9U8CzBbPW7z9Bb+sRI/pSIAhYF8/R8yAm18e+Bvk= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 242E33857831 for ; Wed, 21 Apr 2021 21:32:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 242E33857831 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13LLWL2U005035 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 17:32:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13LLWL2U005035 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F0FA21E789; Wed, 21 Apr 2021 17:32:20 -0400 (EDT) Subject: Re: [PATCH] sim: use -Werror when probing for supported warning flags To: John Baldwin , gdb-patches@sourceware.org References: <20210421185110.2788705-1-simon.marchi@polymtl.ca> Message-ID: <43dfd01b-10b9-aaf3-1568-3329939ce60a@polymtl.ca> Date: Wed, 21 Apr 2021 17:32:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Apr 2021 21:32:21 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-21 5:13 p.m., John Baldwin wrote: > On 4/21/21 2:04 PM, Simon Marchi via Gdb-patches wrote: >> On 2021-04-21 4:44 p.m., Mike Frysinger wrote: >>> On 21 Apr 2021 14:51, Simon Marchi via Gdb-patches wrote: >>>> When building with clang, we get: >>>> >>>>      error: unknown warning option '-Wmissing-parameter-type' [-Werror,-Wunknown-warning-option] >>>> >>>> This is because clang only warns by default when encountering an unknown >>>> warning option, and the probe for supported warning flags is done >>>> without -Werror.  All flags are therefore accepted by configure, but >>>> then it breaks when actually compiling a source file with -Werror. >>>> >>>> This is equivalent to this commit in gdb: >>>> >>>>      3e019bdc20eb81b91ab5bc774386201b874c0bac >>>>      gdb: Use -Werror when checking for (un)supported warning flags >>>> >>>> We then see some other compilation errors when building with clang and >>>> -Werror, they can be dealt with later. >>>> >>>> sim/ChangeLog: >>>> >>>>     * m4/sim_ac_option_warnings.m4 (SIM_AC_OPTION_WARNINGS): >>>>     Use -Werror when probing for supported warning flags. >>> >>> so this one file/line looks fine >>> >>> but the regen looks a little out of whack.  when i apply your patch and >>> regenerate everything, i don't have any aclocal.m4 changes.  why do you ? >>> are you running the tools manually and with a diff -I order ? >>> -mike >>> >> >> I run `autoreconf -vf` inside sim/, using binaries compiled from >> upstream (not my distro's versions). > > Do you have LANG set?  Maybe that affects the collating order used for > sorting? > I do (en_CA.UTF-8). But I tried this, didn't change anything: LC_ALL=C LANG=C autoreconf -vf Simon