From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33462 invoked by alias); 24 Jun 2019 14:12:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33453 invoked by uid 89); 24 Jun 2019 14:12:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:388, HX-Received:adf X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 14:12:46 +0000 Received: by mail-wr1-f65.google.com with SMTP id c2so14087678wrm.8 for ; Mon, 24 Jun 2019 07:12:45 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id t15sm9707370wrx.84.2019.06.24.07.12.43 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 07:12:43 -0700 (PDT) Subject: Re: [PATCH 08/66] Remove tui_list To: Tom Tromey , gdb-patches@sourceware.org References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-9-tom@tromey.com> From: Pedro Alves Message-ID: <43b9d2dc-1e03-80f0-da9e-60ea202d3db7@redhat.com> Date: Mon, 24 Jun 2019 14:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190623224329.16060-9-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00527.txt.bz2 On 6/23/19 11:42 PM, Tom Tromey wrote: > -static struct tui_list source_windows = {src_win_list, 0}; > +static struct std::vector source_windows; I usually prefer to drop "struct", but I can live with it. However, I have to say that "struct std::vector" looks weird. :-) (There are other instances in the patch.) Thanks, Pedro Alves