From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38475 invoked by alias); 12 Apr 2017 14:57:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36855 invoked by uid 89); 12 Apr 2017 14:57:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=9093 X-HELO: mail-wr0-f170.google.com Received: from mail-wr0-f170.google.com (HELO mail-wr0-f170.google.com) (209.85.128.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 14:57:44 +0000 Received: by mail-wr0-f170.google.com with SMTP id l28so19279596wre.0 for ; Wed, 12 Apr 2017 07:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=fqVLy6swA53vVq2hAPqqRgXVDRSZCNo3X4ti6jppaBQ=; b=LVD+tS8qVu+60gsU0UoXv+P3wKjuAAIHYNCC38d5GkQtWacLb0G1ymw+qlROldUBZM JVNDuOUvWKbR54Q+gb6Pvr4gSfvSAtymU3aZu17jD2whxRNzQF/PYyJHJO1ho34nGojT wlVwrKkcH4GnuAUAeaYJAGm9qJ5NcICWoqSySNh3K+rU4D43oMuos5fGKsJz1gYLojIY V29kHb5R948ckeZLB11SIItnoflpGFcGonYCRMmrrWaWA6UUPQUu6vypYhmvpgL1yceA 5Ab2hfpA7QFaTAo5FC2sDM2TFH++8qs9Ly8uxAPyZQvei8CjkfHJp99K7qdwQPRNmxzk KOrg== X-Gm-Message-State: AN3rC/4orGTpXB7oogyvU0BQxzKG7VwnTO026l0IKHLDANTiv3j50En/iYImcOwRcQAyqqNE X-Received: by 10.223.163.17 with SMTP id c17mr3335921wrb.186.1492009063895; Wed, 12 Apr 2017 07:57:43 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id f6sm1916354wrf.13.2017.04.12.07.57.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 07:57:42 -0700 (PDT) Subject: Re: [PATCH] gdb: Move DJGPP/go32 bits to their own tdep file To: Eli Zaretskii References: <1492003875-25394-1-git-send-email-palves@redhat.com> <83bms1ka9s.fsf@gnu.org> <837f2pk7kq.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <43ad7b9b-e1e8-308b-a24d-b1c7a5425777@redhat.com> Date: Wed, 12 Apr 2017 14:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <837f2pk7kq.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00341.txt.bz2 On 04/12/2017 03:45 PM, Eli Zaretskii wrote: > It's fine with me if you decide to make only that change. I just > think that if you had this difficulty with go32 bits, someone else > might have the same difficulty with SVR4 bits. That's why I wrote > what I wrote. Hmm, actually, the SVR4 bits are likely useless by now? It seems to me that the only way to activate them is to manually do "set osabi SVR4". At least according to a grep by GDB_OSABI_SVR4: defs.h: GDB_OSABI_SVR4, i386-tdep.c: gdbarch_register_osabi (bfd_arch_i386, 0, GDB_OSABI_SVR4, I.e., unlike most other ports, there's no osabi sniffer to auto-detect SVR4. Grepping for i386_svr4_init_abi, we see that Solaris is the only other SVR4-like port that reuses the function: i386-tdep.c:4474:i386_svr4_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) i386-tdep.c:9093: i386_svr4_init_abi); i386-tdep.h:433:extern void i386_svr4_init_abi (struct gdbarch_info, struct gdbarch *); i386-sol2-tdep.c:109: i386_svr4_init_abi (info, gdbarch); So maybe we should drop GDB_OSABI_SVR4, and inline/move the i386_svr4_init_abi function to i386-sol2-tdep.c. Thanks, Pedro Alves