From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9083 invoked by alias); 29 Aug 2018 22:32:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9066 invoked by uid 89); 29 Aug 2018 22:32:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:type_co X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 22:32:53 +0000 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 359B23082A35 for ; Wed, 29 Aug 2018 22:32:52 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F2372010CBC for ; Wed, 29 Aug 2018 22:32:52 +0000 (UTC) Subject: Re: [PATCH 9/9] C++ compile support References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> <87tvo0sakn.fsf@tromey.com> <87in3u5qhd.fsf@tromey.com> To: gdb-patches@sourceware.org From: Keith Seitz Message-ID: <43ace4ec-9bee-5f99-c889-8088706afee9@redhat.com> Date: Wed, 29 Aug 2018 22:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <87in3u5qhd.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00785.txt.bz2 On 08/28/2018 10:51 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> The complete list of changes in this revision: > Keith> a) removed "(void)" everywhere > Keith> b) removed compile-cplus-support.c and moved functions to > Keith> private static members of compile_cplus_instance > Keith> c) removed _initialize_XYZ decls > Keith> d) moved decl_name to static member of compile_cplus_instance > Keith> e) used get instead of release in new_scope > Keith> f) KFAIL remaining compile-cplus.exp/compile-cplus-print.exp tests > Keith> and fixed a bug uncovered by missing "_no_output" buglet > Keith> g) std::string --> const char * to avoid allocation > Keith> h) removed type_code_to_string > > Thank you for updating this. This looks good to me. With that, then, I've rebased this series and pushed it. [I also filed bugs for the KFAILs added in the tests. All kfail tests updated with new bug numbers.] Thank you, Tom! Keith