From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11725 invoked by alias); 21 Feb 2006 18:23:39 -0000 Received: (qmail 11707 invoked by uid 22791); 21 Feb 2006 18:23:37 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-04.spheriq.net (HELO fra-del-04.spheriq.net) (195.46.51.100) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Feb 2006 18:23:33 +0000 Received: from fra-out-02.spheriq.net (fra-out-02.spheriq.net [195.46.51.130]) by fra-del-04.spheriq.net with ESMTP id k1LINPJu022593 for ; Tue, 21 Feb 2006 18:23:27 GMT Received: from fra-cus-01.spheriq.net (fra-cus-01.spheriq.net [195.46.51.37]) by fra-out-02.spheriq.net with ESMTP id k1LINOPt026967 for ; Tue, 21 Feb 2006 18:23:25 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-01.spheriq.net with ESMTP id k1LINMqY024178 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Tue, 21 Feb 2006 18:23:23 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6BC8DDA41; Tue, 21 Feb 2006 18:23:18 +0000 (GMT) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CA5B4474F8; Tue, 21 Feb 2006 18:27:02 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHF98520 (AUTH stubbsa); Tue, 21 Feb 2006 18:23:16 GMT Message-ID: <43FB5A0D.6020404@st.com> Date: Tue, 21 Feb 2006 18:27:00 -0000 From: Andrew STUBBS User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Jim Blandy , GDB Patches Subject: Re: [PATCH] Allow spaces in filenames to load command References: <43949300.1040203@st.com> <8f2776cb0512051250u2a6083dbma95e6b352410dea8@mail.gmail.com> <43956C93.5070709@st.com> <8f2776cb0512061504la4a7a5brada0edaeb051f0e4@mail.gmail.com> <8f2776cb0512061912o2d37bef9y7404a51858bfd6cf@mail.gmail.com> <43971EC3.3060405@st.com> <43972145.6020903@st.com> <20060220170702.GH16058@nevyn.them.org> <8f2776cb0602201159r70222f70r538b97cdeb973e79@mail.gmail.com> <20060220200315.GA25393@nevyn.them.org> In-Reply-To: <20060220200315.GA25393@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.01 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00395.txt.bz2 Daniel Jacobowitz wrote: >> Yes --- this look good. >> >> Ideally, the code added to load_command to do the quoting should be in >> libiberty/argv.c. But this patch is fine as is. > > Good enough. We can deal with that separately, or just put it in > utils.c, if we need it again. Thanks, committed. Andrew