From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27142 invoked by alias); 14 Feb 2017 11:24:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27086 invoked by uid 89); 14 Feb 2017 11:24:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LOTSOFHASH,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy=*cmd, ptid_t, field_int, sk:value_c X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40070.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 11:24:15 +0000 Received: from VI1PR0801MB1822.eurprd08.prod.outlook.com (10.168.68.7) by VI1PR0801MB1822.eurprd08.prod.outlook.com (10.168.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Tue, 14 Feb 2017 11:24:03 +0000 Received: from VI1PR0801MB1822.eurprd08.prod.outlook.com ([10.168.68.7]) by VI1PR0801MB1822.eurprd08.prod.outlook.com ([10.168.68.7]) with mapi id 15.01.0888.030; Tue, 14 Feb 2017 11:24:03 +0000 From: Alan Hayward To: Yao Qi CC: Pedro Alves , Joel Brobecker , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Removal of uses of MAX_REGISTER_SIZE Date: Tue, 14 Feb 2017 11:24:00 -0000 Message-ID: <43DE0D94-591B-48F9-9F98-4902A4C91F44@arm.com> References: <45e3a5e1-a9aa-1bc0-5d08-526b89fc458e@redhat.com> <20170201124123.GA27498@E107787-LIN> <20170202094012.dge4r6rsl2skdrii@adacore.com> <20170203102819.GA11916@E107787-LIN> <25716edf-096e-20c5-4170-fb8ca04d897b@redhat.com> <0C6A0D51-4C49-4400-8C46-E77DD512DF56@arm.com> <20170203165022.GB11916@E107787-LIN> <1E0030CE-FB37-4821-AA53-9C6D1CC285C9@arm.com> <20170206152635.GE11916@E107787-LIN> <5F3D30AE-9A53-493A-B6DC-DF594C2FAB18@arm.com> <8660kkpq1l.fsf@gmail.com> In-Reply-To: <8660kkpq1l.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-office365-filtering-correlation-id: 73be4fa0-e414-42cb-0ef2-08d454cbfb2e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:VI1PR0801MB1822; x-microsoft-exchange-diagnostics: 1;VI1PR0801MB1822;7:gwOXlDM9SUGkww9wUvdgDELTLExpMx8qR8eR69hnkZEHJg87V7qs8wEX4SYzvmIv1ugEoGUBgLoXXHE+Fb3O2ZNm/zCUV/rZuDOjQ1TZRihQWZ8DwG1JIdeyMO/owZhAJWTPsDssNcJF2jFBcIVp/NXy996hgf4Jxlp5WyYjerjyyK4jCy4wpCgRyJavwFYmHVbWGm662ijKoYbbmG084XuWnhcTYi9kHZijYIfrehlK8TaMdrlPiVIvjjhpnp5PWMqdU+3OKeGblDcAPTMqInsc+IVfFMctb0PoLVDLNbi9N6br8rCwLkNpOtVX0vTycSywq0+FEBDK40iFA7zCNWnr1r0sSiUCuh6FsV7U46HQtQPqQmA7XOM8kVadoCgMbCQOMMGRbDsrnjcF9Y30eBA5HfY0FWfaazZP2Jb+bblv7C2RcDHPYO5tg8h3IBnRxYUsMAN7V8qgzeCFyUa2+Ofl7fH3zyohrKvLSaThX/YEiInQLHBudbuhhETwVrRczpwC5DeY3u/Xaspa6qQGkA== nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123558025)(20161123555025)(20161123560025)(6072148);SRVR:VI1PR0801MB1822;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1822; x-forefront-prvs: 0218A015FA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39860400002)(39840400002)(189002)(377424004)(199003)(24454002)(81003)(39060400002)(66066001)(3280700002)(189998001)(6506006)(6436002)(92566002)(25786008)(110136004)(38730400002)(6116002)(2906002)(106356001)(3846002)(102836003)(86362001)(575784001)(6486002)(97736004)(4326007)(36756003)(77096006)(53936002)(105586002)(2900100001)(68736007)(229853002)(106116001)(5660300001)(82746002)(81156014)(7736002)(3660700001)(50986999)(6916009)(122556002)(33656002)(83716003)(101416001)(53546003)(76176999)(6246003)(99286003)(54906002)(6512007)(1411001)(8676002)(305945005)(2950100002)(81166006)(8936002)(93886004)(54356999)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0801MB1822;H:VI1PR0801MB1822.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2017 11:24:02.8320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1822 X-SW-Source: 2017-02/txt/msg00381.txt.bz2 DQo+IE9uIDggRmViIDIwMTcsIGF0IDE3OjA5LCBZYW8gUWkgPHFpeWFvbHRj QGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiBBbGFuIEhheXdhcmQgPEFsYW4u SGF5d2FyZEBhcm0uY29tPiB3cml0ZXM6DQo+IA0KPj4gQEAgLTExMzUsOCAr MTEzNSw4IEBAIHJlZ2lzdGVyX2NoYW5nZWRfcCAoaW50IHJlZ251bSwgc3Ry dWN0IHJlZ2NhY2hlICpwcmV2X3JlZ3MsDQo+PiAJCSAgICBzdHJ1Y3QgcmVn Y2FjaGUgKnRoaXNfcmVncykNCj4+IHsNCj4+ICAgc3RydWN0IGdkYmFyY2gg KmdkYmFyY2ggPSBnZXRfcmVnY2FjaGVfYXJjaCAodGhpc19yZWdzKTsNCj4+ IC0gIGdkYl9ieXRlIHByZXZfYnVmZmVyW01BWF9SRUdJU1RFUl9TSVpFXTsN Cj4+IC0gIGdkYl9ieXRlIHRoaXNfYnVmZmVyW01BWF9SRUdJU1RFUl9TSVpF XTsNCj4+ICsgIHN0ZDo6dmVjdG9yPGdkYl9ieXRlPiBwcmV2X2J1ZmZlciAo cmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwgcmVnbnVtKSk7DQo+PiArICBzdGQ6 OnZlY3RvcjxnZGJfYnl0ZT4gdGhpc19idWZmZXIgKHJlZ2lzdGVyX3NpemUg KGdkYmFyY2gsIHJlZ251bSkpOw0KPj4gICBlbnVtIHJlZ2lzdGVyX3N0YXR1 cyBwcmV2X3N0YXR1czsNCj4+ICAgZW51bSByZWdpc3Rlcl9zdGF0dXMgdGhp c19zdGF0dXM7DQo+PiANCj4gDQo+IFRoaXMgZnVuY3Rpb24gc2hvdWxkIGJl IG1vdmVkIHRvIHJlZ2NhY2hlLmMsIGJlY2F1c2UgaXQgaXMgYWJvdXQNCj4g Y29tcGFyaW5nIGJ5dGVzIG9mIGEgY2VydGFpbiByZWdpc3RlciBpbiBib3Ro IHJlZ2NhY2hlcy4gIFRoZW4sIHdlbiBjYW4NCj4gY29tcGFyZSByYXcgcmVn aXN0ZXJzIGZyb20gcmVnaXN0ZXJfYnVmZmVyLCBhbmQgcHNldWRvIHJlZ2lz dGVycyBmcm9tDQo+IHRoZSB2YWx1ZXMuDQo+IA0KPj4gQEAgLTExNDYsMTMg KzExNDYsMTMgQEAgcmVnaXN0ZXJfY2hhbmdlZF9wIChpbnQgcmVnbnVtLCBz dHJ1Y3QgcmVnY2FjaGUgKnByZXZfcmVncywNCj4+ICAgICByZXR1cm4gMTsN Cj4+IA0KPj4gICAvKiBHZXQgcmVnaXN0ZXIgY29udGVudHMgYW5kIGNvbXBh cmUuICAqLw0KPj4gLSAgcHJldl9zdGF0dXMgPSByZWdjYWNoZV9jb29rZWRf cmVhZCAocHJldl9yZWdzLCByZWdudW0sIHByZXZfYnVmZmVyKTsNCj4+IC0g IHRoaXNfc3RhdHVzID0gcmVnY2FjaGVfY29va2VkX3JlYWQgKHRoaXNfcmVn cywgcmVnbnVtLCB0aGlzX2J1ZmZlcik7DQo+PiArICBwcmV2X3N0YXR1cyA9 IHJlZ2NhY2hlX2Nvb2tlZF9yZWFkIChwcmV2X3JlZ3MsIHJlZ251bSwgcHJl dl9idWZmZXIuZGF0YSAoKSk7DQo+PiArICB0aGlzX3N0YXR1cyA9IHJlZ2Nh Y2hlX2Nvb2tlZF9yZWFkICh0aGlzX3JlZ3MsIHJlZ251bSwgdGhpc19idWZm ZXIuZGF0YSAoKSk7DQo+PiANCj4+ICAgaWYgKHRoaXNfc3RhdHVzICE9IHBy ZXZfc3RhdHVzKQ0KPj4gICAgIHJldHVybiAxOw0KPj4gICBlbHNlIGlmICh0 aGlzX3N0YXR1cyA9PSBSRUdfVkFMSUQpDQo+PiAtICAgIHJldHVybiBtZW1j bXAgKHByZXZfYnVmZmVyLCB0aGlzX2J1ZmZlciwNCj4+ICsgICAgcmV0dXJu IG1lbWNtcCAocHJldl9idWZmZXIuZGF0YSAoKSwgdGhpc19idWZmZXIuZGF0 YSAoKSwNCj4+IAkJICAgcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwgcmVnbnVt KSkgIT0gMDsNCj4+ICAgZWxzZQ0KPj4gICAgIHJldHVybiAwOw0KPiANCj4g LS0gDQo+IFlhbyAo6b2Q5bCnKQ0KDQoNCklnbm9yZSBteSBwcmV2aW91cyBy ZXBseSB0byB0aGlzIGNvbW1lbnQuIEkndmUgc2luY2Ugbm90aWNlZCB5b3Ug Y2FuIGp1c3QgdXNlDQpyZWdjYWNoZV9jb29rZWRfcmVhZF92YWx1ZS4NCg0K TmV3IHBhdGNoIGJlbG93Lg0KDQpJIHJlbW92ZWQgdGhlIGVycm9yIGNhc2Ug ZnJvbSBtaS1tYWluIGJlY3Vhc2UgaXQgd2FzIGltcG9zc2libGUgZm9yIHRo ZSBjb2RlDQp0byBnZXQgaGVyZSAtIHJlZ2lzdGVyX2NoYW5nZWRfcCB3b3Vs ZCBhbHdheXMgcmV0dXJuIDAgb3IgMS4NCg0KVGVzdGVkIG9uIGEgYnVpbGQg b2YgYWxsIHRhcmdldHMgdXNpbmcgbWFrZSBjaGVjayB3aXRoIHRhcmdldCBi b2FyZHMgdW5peCBhbmQNCm5hdGl2ZS1nZGJzZXJ2ZXIuIFRoaXMgdGVzdGlu ZyBhbHNvIGluY2x1ZGVkIHRoZSB0d28gcGF0Y2hlczoNCiogTTY4S19NQVhf UkVHSVNURVJfU0laRSBhbmQgSTM4Nl9NQVhfUkVHSVNURVJfU0laRSBjaGFu Z2VzDQoqIHN0YWNrLmMgY2hhbmdlcw0KDQpPaz8NCg0KQWxhbi4NCg0KDQoy MDE3LTAyLTEzICBBbGFuIEhheXdhcmQgIDxhbGFuLmhheXdhcmRAYXJtLmNv bT4NCg0KCSogZ2RiL21pL21pLW1haW4uYyAobWlfY21kX2RhdGFfbGlzdF9j aGFuZ2VkX3JlZ2lzdGVycyk6IFVzZQ0KCXJlZ2NhY2hlX3JlZ2lzdGVyX2No YW5nZWRfcA0KCShyZWdpc3Rlcl9jaGFuZ2VkX3ApOiBSZW1vdmUuDQoJKiBn ZGIvcmVnY2FjaGUuYyAocmVnY2FjaGVfcmVnaXN0ZXJfY2hhbmdlZF9wKTog TmV3IGZ1bmN0aW9uLg0KCSogZ2RiL3JlZ2NhY2hlLmggKHJlZ2NhY2hlX3Jl Z2lzdGVyX2NoYW5nZWRfcCk6IE5ldyBkZWNsYXJhdGlvbi4NCg0KDQpkaWZm IC0tZ2l0IGEvZ2RiL21pL21pLW1haW4uYyBiL2dkYi9taS9taS1tYWluLmMN CmluZGV4IDU3YzIzZWJmNWQ2YjJkM2IzOThhYTQwZWJkOWIzY2I3MGM1NjEy NWMuLmQyMmNiOWI1OWQzYzVkNjU2MDliZjM3NjI0NTdiYmE5MDQwMWZkOGYg MTAwNjQ0DQotLS0gYS9nZGIvbWkvbWktbWFpbi5jDQorKysgYi9nZGIvbWkv bWktbWFpbi5jDQpAQCAtOTEsOCArOTEsNiBAQCBzdGF0aWMgdm9pZCBtaV9l eGVjdXRlX2NsaV9jb21tYW5kIChjb25zdCBjaGFyICpjbWQsIGludCBhcmdz X3AsDQogCQkJCSAgICBjb25zdCBjaGFyICphcmdzKTsNCiBzdGF0aWMgdm9p ZCBtaV9leGVjdXRlX2FzeW5jX2NsaV9jb21tYW5kIChjaGFyICpjbGlfY29t bWFuZCwNCiAJCQkJCSAgY2hhciAqKmFyZ3YsIGludCBhcmdjKTsNCi1zdGF0 aWMgaW50IHJlZ2lzdGVyX2NoYW5nZWRfcCAoaW50IHJlZ251bSwgc3RydWN0 IHJlZ2NhY2hlICosDQotCQkJICAgICAgIHN0cnVjdCByZWdjYWNoZSAqKTsN CiBzdGF0aWMgdm9pZCBvdXRwdXRfcmVnaXN0ZXIgKHN0cnVjdCBmcmFtZV9p bmZvICosIGludCByZWdudW0sIGludCBmb3JtYXQsDQogCQkJICAgICBpbnQg c2tpcF91bmF2YWlsYWJsZSk7DQoNCkBAIC0xMDk4LDExICsxMDk2LDcgQEAg bWlfY21kX2RhdGFfbGlzdF9jaGFuZ2VkX3JlZ2lzdGVycyAoY2hhciAqY29t bWFuZCwgY2hhciAqKmFyZ3YsIGludCBhcmdjKQ0KIAkgIGlmIChnZGJhcmNo X3JlZ2lzdGVyX25hbWUgKGdkYmFyY2gsIHJlZ251bSkgPT0gTlVMTA0KIAkg ICAgICB8fCAqKGdkYmFyY2hfcmVnaXN0ZXJfbmFtZSAoZ2RiYXJjaCwgcmVn bnVtKSkgPT0gJ1wwJykNCiAJICAgIGNvbnRpbnVlOw0KLQkgIGNoYW5nZWQg PSByZWdpc3Rlcl9jaGFuZ2VkX3AgKHJlZ251bSwgcHJldl9yZWdzLCB0aGlz X3JlZ3MpOw0KLQkgIGlmIChjaGFuZ2VkIDwgMCkNCi0JICAgIGVycm9yIChf KCItZGF0YS1saXN0LWNoYW5nZWQtcmVnaXN0ZXJzOiAiDQotCQkgICAgICJV bmFibGUgdG8gcmVhZCByZWdpc3RlciBjb250ZW50cy4iKSk7DQotCSAgZWxz ZSBpZiAoY2hhbmdlZCkNCisJICBpZiAocmVnY2FjaGVfcmVnaXN0ZXJfY2hh bmdlZF9wIChyZWdudW0sIHByZXZfcmVncywgdGhpc19yZWdzKSkNCiAJICAg IHVpb3V0LT5maWVsZF9pbnQgKE5VTEwsIHJlZ251bSk7DQogCX0NCiAgICAg fQ0KQEAgLTExMTcsMTEgKzExMTEsNyBAQCBtaV9jbWRfZGF0YV9saXN0X2No YW5nZWRfcmVnaXN0ZXJzIChjaGFyICpjb21tYW5kLCBjaGFyICoqYXJndiwg aW50IGFyZ2MpDQogCSAgJiYgZ2RiYXJjaF9yZWdpc3Rlcl9uYW1lIChnZGJh cmNoLCByZWdudW0pICE9IE5VTEwNCiAJICAmJiAqZ2RiYXJjaF9yZWdpc3Rl cl9uYW1lIChnZGJhcmNoLCByZWdudW0pICE9ICdcMDAwJykNCiAJew0KLQkg IGNoYW5nZWQgPSByZWdpc3Rlcl9jaGFuZ2VkX3AgKHJlZ251bSwgcHJldl9y ZWdzLCB0aGlzX3JlZ3MpOw0KLQkgIGlmIChjaGFuZ2VkIDwgMCkNCi0JICAg IGVycm9yIChfKCItZGF0YS1saXN0LWNoYW5nZWQtcmVnaXN0ZXJzOiAiDQot CQkgICAgICJVbmFibGUgdG8gcmVhZCByZWdpc3RlciBjb250ZW50cy4iKSk7 DQotCSAgZWxzZSBpZiAoY2hhbmdlZCkNCisJICBpZiAocmVnY2FjaGVfcmVn aXN0ZXJfY2hhbmdlZF9wIChyZWdudW0sIHByZXZfcmVncywgdGhpc19yZWdz KSkNCiAJICAgIHVpb3V0LT5maWVsZF9pbnQgKE5VTEwsIHJlZ251bSk7DQog CX0NCiAgICAgICBlbHNlDQpAQCAtMTEzMCwzNCArMTEyMCw2IEBAIG1pX2Nt ZF9kYXRhX2xpc3RfY2hhbmdlZF9yZWdpc3RlcnMgKGNoYXIgKmNvbW1hbmQs IGNoYXIgKiphcmd2LCBpbnQgYXJnYykNCiAgIGRvX2NsZWFudXBzIChjbGVh bnVwKTsNCiB9DQoNCi1zdGF0aWMgaW50DQotcmVnaXN0ZXJfY2hhbmdlZF9w IChpbnQgcmVnbnVtLCBzdHJ1Y3QgcmVnY2FjaGUgKnByZXZfcmVncywNCi0J CSAgICBzdHJ1Y3QgcmVnY2FjaGUgKnRoaXNfcmVncykNCi17DQotICBzdHJ1 Y3QgZ2RiYXJjaCAqZ2RiYXJjaCA9IGdldF9yZWdjYWNoZV9hcmNoICh0aGlz X3JlZ3MpOw0KLSAgZ2RiX2J5dGUgcHJldl9idWZmZXJbTUFYX1JFR0lTVEVS X1NJWkVdOw0KLSAgZ2RiX2J5dGUgdGhpc19idWZmZXJbTUFYX1JFR0lTVEVS X1NJWkVdOw0KLSAgZW51bSByZWdpc3Rlcl9zdGF0dXMgcHJldl9zdGF0dXM7 DQotICBlbnVtIHJlZ2lzdGVyX3N0YXR1cyB0aGlzX3N0YXR1czsNCi0NCi0g IC8qIEZpcnN0IHRpbWUgdGhyb3VnaCBvciBhZnRlciBnZGJhcmNoIGNoYW5n ZSBjb25zaWRlciBhbGwgcmVnaXN0ZXJzDQotICAgICBhcyBjaGFuZ2VkLiAg Ki8NCi0gIGlmICghcHJldl9yZWdzIHx8IGdldF9yZWdjYWNoZV9hcmNoIChw cmV2X3JlZ3MpICE9IGdkYmFyY2gpDQotICAgIHJldHVybiAxOw0KLQ0KLSAg LyogR2V0IHJlZ2lzdGVyIGNvbnRlbnRzIGFuZCBjb21wYXJlLiAgKi8NCi0g IHByZXZfc3RhdHVzID0gcmVnY2FjaGVfY29va2VkX3JlYWQgKHByZXZfcmVn cywgcmVnbnVtLCBwcmV2X2J1ZmZlcik7DQotICB0aGlzX3N0YXR1cyA9IHJl Z2NhY2hlX2Nvb2tlZF9yZWFkICh0aGlzX3JlZ3MsIHJlZ251bSwgdGhpc19i dWZmZXIpOw0KLQ0KLSAgaWYgKHRoaXNfc3RhdHVzICE9IHByZXZfc3RhdHVz KQ0KLSAgICByZXR1cm4gMTsNCi0gIGVsc2UgaWYgKHRoaXNfc3RhdHVzID09 IFJFR19WQUxJRCkNCi0gICAgcmV0dXJuIG1lbWNtcCAocHJldl9idWZmZXIs IHRoaXNfYnVmZmVyLA0KLQkJICAgcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwg cmVnbnVtKSkgIT0gMDsNCi0gIGVsc2UNCi0gICAgcmV0dXJuIDA7DQotfQ0K LQ0KIC8qIFJldHVybiBhIGxpc3Qgb2YgcmVnaXN0ZXIgbnVtYmVyIGFuZCB2 YWx1ZSBwYWlycy4gIFRoZSB2YWxpZA0KICAgIGFyZ3VtZW50cyBleHBlY3Rl ZCBhcmU6IGEgbGV0dGVyIGluZGljYXRpbmcgdGhlIGZvcm1hdCBpbiB3aGlj aCB0bw0KICAgIGRpc3BsYXkgdGhlIHJlZ2lzdGVycyBjb250ZW50cy4gIFRo aXMgY2FuIGJlIG9uZSBvZjogeA0KZGlmZiAtLWdpdCBhL2dkYi9yZWdjYWNo ZS5oIGIvZ2RiL3JlZ2NhY2hlLmgNCmluZGV4IGU1YTdjZjU1MzI3OWI4Y2Mw ZDU0NmVjMWI4Mjc0Y2JmOTdlMjQ2ZDUuLjE3NGFhMDE2NmY0MTliNDBiMDUw OWIxYmU1YzZkY2UzYzIzNzNmZDAgMTAwNjQ0DQotLS0gYS9nZGIvcmVnY2Fj aGUuaA0KKysrIGIvZ2RiL3JlZ2NhY2hlLmgNCkBAIC0yMjgsNCArMjI4LDEx IEBAIGV4dGVybiB2b2lkIHJlZ2NhY2hlX2NweSAoc3RydWN0IHJlZ2NhY2hl ICpkZXN0LCBzdHJ1Y3QgcmVnY2FjaGUgKnNyYyk7DQogZXh0ZXJuIHZvaWQg cmVnaXN0ZXJzX2NoYW5nZWQgKHZvaWQpOw0KIGV4dGVybiB2b2lkIHJlZ2lz dGVyc19jaGFuZ2VkX3B0aWQgKHB0aWRfdCk7DQoNCisvKiBSZXR1cm4gdHJ1 ZSBpZiB0aGUgcmVnaXN0ZXIgdmFsdWUgb2YgcmVnbnVtIGRpZmZlcnMgYmV0 d2VlbiBwcmV2X3JlZ3MgYW5kDQorICAgdGhpc19yZWdzLiAgcHJldl9yZWdz IGNhbiBiZSBudWxsLCBidXQgdGhpc19yZWdzIG11c3QgYmUgc2V0LiAgKi8N CisNCitleHRlcm4gYm9vbCByZWdjYWNoZV9yZWdpc3Rlcl9jaGFuZ2VkX3Ag KGludCByZWdudW0sDQorCQkJCQkgc3RydWN0IHJlZ2NhY2hlICpwcmV2X3Jl Z3MsDQorCQkJCQkgc3RydWN0IHJlZ2NhY2hlICp0aGlzX3JlZ3MpOw0KKw0K ICNlbmRpZiAvKiBSRUdDQUNIRV9IICovDQpkaWZmIC0tZ2l0IGEvZ2RiL3Jl Z2NhY2hlLmMgYi9nZGIvcmVnY2FjaGUuYw0KaW5kZXggOWQyOGFhMmMyMTE0 ZTBmMWM1Mjc1OGJiMmZiZTk2NjlhMzI5YzEzZS4uOTZjYzk0ZWU3Y2ZlYjYw ZDNiNjU0MWNhMGI0OTg3MWU2MDg3YWE4YSAxMDA2NDQNCi0tLSBhL2dkYi9y ZWdjYWNoZS5jDQorKysgYi9nZGIvcmVnY2FjaGUuYw0KQEAgLTEyNTEsNiAr MTI1MSw3NCBAQCByZWdjYWNoZV93cml0ZV9wYyAoc3RydWN0IHJlZ2NhY2hl ICpyZWdjYWNoZSwgQ09SRV9BRERSIHBjKQ0KIH0NCg0KDQorLyogUmV0dXJu IHRydWUgaWYgdGhlIHJlZ2lzdGVyIHZhbHVlIG9mIHJlZ251bSBkaWZmZXJz IGJldHdlZW4gcHJldl9yZWdzIGFuZA0KKyAgIHRoaXNfcmVncy4gIHByZXZf cmVncyBjYW4gYmUgbnVsbCwgYnV0IHRoaXNfcmVncyBtdXN0IGJlIHNldC4g ICovDQorDQorYm9vbA0KK3JlZ2NhY2hlX3JlZ2lzdGVyX2NoYW5nZWRfcCAo aW50IHJlZ251bSwgc3RydWN0IHJlZ2NhY2hlICpwcmV2X3JlZ3MsDQorCQkJ ICAgICBzdHJ1Y3QgcmVnY2FjaGUgKnRoaXNfcmVncykNCit7DQorICBzdHJ1 Y3QgZ2RiYXJjaCAqZ2RiYXJjaDsNCisgIGdkYl9hc3NlcnQgKHJlZ251bSA+ PSAwKTsNCisgIGdkYl9hc3NlcnQgKHRoaXNfcmVncyk7DQorDQorICAvKiBp ZiB0aGVyZSBhcmUgbm8gcHJldmlvdXMgcmVnaXN0ZXJzIGNvbnNpZGVyIGFs bCByZWdpc3RlcnMgYXMgY2hhbmdlZC4gICovDQorICBpZiAoIXByZXZfcmVn cykNCisgICAgcmV0dXJuIHRydWU7DQorDQorICBnZGJfYXNzZXJ0IChyZWdu dW0gPCBwcmV2X3JlZ3MtPmRlc2NyLT5ucl9jb29rZWRfcmVnaXN0ZXJzKTsN CisgIGdkYl9hc3NlcnQgKHJlZ251bSA8IHRoaXNfcmVncy0+ZGVzY3ItPm5y X2Nvb2tlZF9yZWdpc3RlcnMpOw0KKyAgZ2RiYXJjaCA9IGdldF9yZWdjYWNo ZV9hcmNoICh0aGlzX3JlZ3MpOw0KKw0KKyAgLyogSWYgYXJjaGVzIGRvbid0 IG1hdGNoIHRoZW4gY29uc2lkZXIgYWxsIHJlZ2lzdGVycyBhcyBjaGFuZ2Vk LiAgKi8NCisgIGlmIChnZGJhcmNoICE9IGdldF9yZWdjYWNoZV9hcmNoIChw cmV2X3JlZ3MpKQ0KKyAgICByZXR1cm4gdHJ1ZTsNCisNCisgIGlmIChyZWdu dW0gPCB0aGlzX3JlZ3MtPmRlc2NyLT5ucl9yYXdfcmVnaXN0ZXJzKQ0KKyAg ICB7DQorICAgICAgZW51bSByZWdpc3Rlcl9zdGF0dXMgcHJldl9zdGF0dXMs IHRoaXNfc3RhdHVzOw0KKw0KKyAgICAgIHByZXZfc3RhdHVzID0gKGVudW0g cmVnaXN0ZXJfc3RhdHVzKSBwcmV2X3JlZ3MtPnJlZ2lzdGVyX3N0YXR1c1ty ZWdudW1dOw0KKyAgICAgIHRoaXNfc3RhdHVzID0gKGVudW0gcmVnaXN0ZXJf c3RhdHVzKSB0aGlzX3JlZ3MtPnJlZ2lzdGVyX3N0YXR1c1tyZWdudW1dOw0K Kw0KKyAgICAgIGlmICh0aGlzX3N0YXR1cyAhPSBwcmV2X3N0YXR1cykNCisJ cmV0dXJuIHRydWU7DQorICAgICAgZWxzZSBpZiAodGhpc19zdGF0dXMgPT0g UkVHX1ZBTElEKQ0KKwlyZXR1cm4gbWVtY21wIChyZWdpc3Rlcl9idWZmZXIg KHByZXZfcmVncywgcmVnbnVtKSwNCisJCSAgICAgICByZWdpc3Rlcl9idWZm ZXIgKHRoaXNfcmVncywgcmVnbnVtKSwNCisJCSAgICAgICByZWdpc3Rlcl9z aXplIChnZGJhcmNoLCByZWdudW0pKSAhPSAwOw0KKyAgICAgIGVsc2UNCisJ cmV0dXJuIGZhbHNlOw0KKyAgICB9DQorICBlbHNlDQorICAgIHsNCisgICAg ICBzdHJ1Y3QgdmFsdWUgKnByZXZfdmFsdWUsICp0aGlzX3ZhbHVlOw0KKyAg ICAgIGJvb2wgcmV0Ow0KKw0KKyAgICAgIHByZXZfdmFsdWUgPSByZWdjYWNo ZV9jb29rZWRfcmVhZF92YWx1ZSAocHJldl9yZWdzLCByZWdudW0pOw0KKyAg ICAgIHRoaXNfdmFsdWUgPSByZWdjYWNoZV9jb29rZWRfcmVhZF92YWx1ZSAo dGhpc19yZWdzLCByZWdudW0pOw0KKw0KKyAgICAgIGlmICh2YWx1ZV9vcHRp bWl6ZWRfb3V0IChwcmV2X3ZhbHVlKQ0KKwkgIHx8IHZhbHVlX29wdGltaXpl ZF9vdXQgKHRoaXNfdmFsdWUpKQ0KKwlyZXQgPSB2YWx1ZV9vcHRpbWl6ZWRf b3V0IChwcmV2X3ZhbHVlKQ0KKwkgICAgICAhPSB2YWx1ZV9vcHRpbWl6ZWRf b3V0ICh0aGlzX3ZhbHVlKTsNCisgICAgICBlbHNlIGlmICghdmFsdWVfZW50 aXJlbHlfYXZhaWxhYmxlIChwcmV2X3ZhbHVlKQ0KKwkgIHx8ICF2YWx1ZV9l bnRpcmVseV9hdmFpbGFibGUgKHRoaXNfdmFsdWUpKQ0KKwlyZXQgPSB2YWx1 ZV9lbnRpcmVseV9hdmFpbGFibGUgKHByZXZfdmFsdWUpDQorCSAgICAgICE9 IHZhbHVlX2VudGlyZWx5X2F2YWlsYWJsZSAodGhpc192YWx1ZSk7DQorICAg ICAgZWxzZQ0KKwlyZXQgPSBtZW1jbXAgKHZhbHVlX2NvbnRlbnRzX3JhdyAo cHJldl92YWx1ZSksDQorCQkgICAgICB2YWx1ZV9jb250ZW50c19yYXcgKHRo aXNfdmFsdWUpLA0KKwkJICAgICAgcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCwg cmVnbnVtKSkgIT0gMDsNCisNCisgICAgICByZWxlYXNlX3ZhbHVlIChwcmV2 X3ZhbHVlKTsNCisgICAgICB2YWx1ZV9mcmVlIChwcmV2X3ZhbHVlKTsNCisg ICAgICByZWxlYXNlX3ZhbHVlICh0aGlzX3ZhbHVlKTsNCisgICAgICB2YWx1 ZV9mcmVlICh0aGlzX3ZhbHVlKTsNCisgICAgICByZXR1cm4gcmV0Ow0KKyAg ICB9DQorfQ0KKw0KIHN0YXRpYyB2b2lkDQogcmVnX2ZsdXNoX2NvbW1hbmQg KGNoYXIgKmNvbW1hbmQsIGludCBmcm9tX3R0eSkNCiB7DQoNCg0KDQo= >From gdb-patches-return-137005-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Feb 14 12:59:19 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 13161 invoked by alias); 14 Feb 2017 12:59:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 13152 invoked by uid 89); 14 Feb 2017 12:59:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=1197, 119,7, runto_main, UD:implptrpiece.exp X-HELO: mail-qt0-f196.google.com Received: from mail-qt0-f196.google.com (HELO mail-qt0-f196.google.com) (209.85.216.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 12:59:15 +0000 Received: by mail-qt0-f196.google.com with SMTP id w20so17055414qtb.1 for ; Tue, 14 Feb 2017 04:59:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Zh5L3dCuIiby61StVMg+O8ilvtDRfWMQC4kAV+l0+1M=; b=H86oVSQPmn6AMbIdSwx9kKTpJ9CkKlXN68eBRGZEHNkhLUyHSq9qsIbnWhhA5tH8En Op3ytJwp7LgULX3o/f11WNGKKSHhzStpwTrV/hioyT0dBbIY7XFgrJebTCvYITOBvRRG 3Q6CS4DerBY7oy5/UTAPOxTwP4jaKF/ca0aIGtS3wE85aeGN575siHvaOqF8Trauothx hAe2PlBfJuw62tcfBIehtXz0WqnTuCjSeeqhJmkA5WQQmn3HJObg8p+gTfk+IcpgUMEZ d29brUZhozoRrPanlRjSFrLjX6OQu+PfVZyz6EYsoxLoQZt77P6gtfCpPj3aiySQtCYr yPOA== X-Gm-Message-State: AMke39lNMxY1oyGkc5HozKFrY3VphmJwrlqZQ9hHlvVtcKgBChR8lBY99y0UPgGacc0XtcX90w2nbTjQU7aUdA== X-Received: by 10.237.34.150 with SMTP id p22mr25845098qtc.76.1487077153573; Tue, 14 Feb 2017 04:59:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.140.194 with HTTP; Tue, 14 Feb 2017 04:59:13 -0800 (PST) In-Reply-To: References: From: Yao Qi Date: Tue, 14 Feb 2017 12:59:00 -0000 Message-ID: Subject: Re: [PATCH] Big-endian targets: Fix implptrpiece.exp To: Andreas Arnez Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00382.txt.bz2 Content-length: 1771 Hi Andreas, Sorry for the delayed review. I read this patch at least twice in the last month, but didn't review because I can't understand it fully, and was interrupted to do something else. On Thu, Jan 19, 2017 at 12:52 PM, Andreas Arnez wrote: > The test case implptrpiece.exp accesses the second byte of the short > integer number 1 and expects it to be zero. This is valid for > little-endian targets, but fails on big-endian targets. > > This is fixed by determining the expected value in an > endianness-independent way. This is quite clever, but I don't like it, :) because every time I read it, it takes me a while what is the test trying to do. > > gdb/testsuite/ChangeLog: > > * gdb.dwarf2/implptrpiece.exp: Fix check for big-endian targets. > --- > gdb/testsuite/gdb.dwarf2/implptrpiece.exp | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/implptrpiece.exp b/gdb/testsuite/gd= b.dwarf2/implptrpiece.exp > index af7dd37..3f6e0d6 100644 > --- a/gdb/testsuite/gdb.dwarf2/implptrpiece.exp > +++ b/gdb/testsuite/gdb.dwarf2/implptrpiece.exp > @@ -119,4 +119,7 @@ if ![runto_main] { > return -1 > } > > -gdb_test "print/d p\[-1\]" " =3D 0" > +# Access the second byte of s through an implicit pointer to the third > +# byte of s, using a negative offset. Compare that to the second byte of > +# the short integer 1 in target byte order. > +gdb_test "p/d p\[-1\] - ((signed char *)(short\[1\]){1})\[1\]" " =3D 0" > -- Can we check the result of p[-1] explicitly for different endianness? We can fill in the first two bytes of s with 0x5678, for example, and it is expected to see different results of p[-1] for different endianness. --=20 Yao (=E9=BD=90=E5=B0=A7)