Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Fix LP64 model bug in PPC simulator
Date: Wed, 25 Jan 2006 17:32:00 -0000	[thread overview]
Message-ID: <43D7B622.2040409@codesourcery.com> (raw)
In-Reply-To: <5981.192.87.1.22.1138179926.squirrel@webmail.xs4all.nl>

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Mark Kettenis wrote:

> Sorry that I didn't notice it before but can you change natural32 as well?

Sure -- I'm sorry I missed that.  I checked in the attached patch after
confirming that the simulator still worked on x86_64-unknown-linux-gnu.

I interpreted your note as an implicit approval of such a change.  I
hope that's OK; let me know if that was a breach of protocol, and I'll
back the patch out.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

[-- Attachment #2: gdb.sim.patch --]
[-- Type: text/plain, Size: 815 bytes --]

2006-01-25  Mark Mitchell  <mark@codesourcery.com>

	* words.h (natural32): Define as "int".

Index: words.h
===================================================================
RCS file: /cvs/src/src/sim/ppc/words.h,v
retrieving revision 1.3
diff -c -5 -p -r1.3 words.h
*** words.h	24 Jan 2006 23:48:01 -0000	1.3
--- words.h	25 Jan 2006 17:27:46 -0000
***************
*** 49,59 ****
  #endif
  
  /* bit based */
  typedef char natural8;
  typedef short natural16;
! typedef long natural32;
  
  typedef signed char signed8;
  typedef signed short signed16;
  typedef signed int signed32;
  
--- 49,59 ----
  #endif
  
  /* bit based */
  typedef char natural8;
  typedef short natural16;
! typedef int natural32;
  
  typedef signed char signed8;
  typedef signed short signed16;
  typedef signed int signed32;
  

  parent reply	other threads:[~2006-01-25 17:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24  5:55 Mark Mitchell
2006-01-24 19:27 ` Mark Kettenis
2006-01-24 19:52   ` Mark Mitchell
2006-01-24 21:09     ` Daniel Jacobowitz
2006-01-24 21:45       ` Mark Kettenis
2006-01-24 23:49       ` Mark Mitchell
     [not found]         ` <5981.192.87.1.22.1138179926.squirrel@webmail.xs4all.nl>
2006-01-25 17:32           ` Mark Mitchell [this message]
2006-01-25 23:08             ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43D7B622.2040409@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox