From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9681 invoked by alias); 24 Jan 2006 23:49:46 -0000 Received: (qmail 9673 invoked by uid 22791); 24 Jan 2006 23:49:46 -0000 X-Spam-Check-By: sourceware.org Received: from voldemort.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jan 2006 23:49:45 +0000 Received: (qmail 19467 invoked from network); 24 Jan 2006 23:49:43 -0000 Received: from unknown (HELO ?192.168.0.3?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jan 2006 23:49:43 -0000 Message-ID: <43D6BD0F.6030500@codesourcery.com> Date: Tue, 24 Jan 2006 23:49:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) MIME-Version: 1.0 To: Daniel Jacobowitz CC: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: PATCH: Fix LP64 model bug in PPC simulator References: <200601240555.k0O5tGmu007234@sethra.codesourcery.com> <200601241925.k0OJPwwt002920@elgar.sibelius.xs4all.nl> <43D68566.4090101@codesourcery.com> <20060124210859.GA26974@nevyn.them.org> In-Reply-To: <20060124210859.GA26974@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------010002020601050807020404" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00393.txt.bz2 This is a multi-part message in MIME format. --------------010002020601050807020404 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 384 Daniel Jacobowitz wrote: > On Tue, Jan 24, 2006 at 11:52:06AM -0800, Mark Mitchell wrote: > >>Mark Kettenis wrote: >> >> >>>Any reason not to just use 'int'? I'm pretty sure our code base makes >>>that assumption in a lot of places. >> >>Fine by me. OK with that change? Here's what I checked in. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713 --------------010002020601050807020404 Content-Type: text/plain; name="gdb.sim.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdb.sim.patch" Content-length: 1245 2006-01-23 Mark Mitchell * words.h (signed32): Define as "int". (unsigned32): Define as "unsigned int". Index: words.h =================================================================== RCS file: /cvs/src/src/sim/ppc/words.h,v retrieving revision 1.2 diff -c -5 -p -r1.2 words.h *** words.h 20 Apr 2005 14:43:55 -0000 1.2 --- words.h 24 Jan 2006 23:47:26 -0000 *************** typedef char natural8; *** 53,67 **** typedef short natural16; typedef long natural32; typedef signed char signed8; typedef signed short signed16; ! typedef signed long signed32; typedef unsigned char unsigned8; typedef unsigned short unsigned16; ! typedef unsigned long unsigned32; #ifdef __GNUC__ typedef long long natural64; typedef signed long long signed64; typedef unsigned long long unsigned64; --- 53,67 ---- typedef short natural16; typedef long natural32; typedef signed char signed8; typedef signed short signed16; ! typedef signed int signed32; typedef unsigned char unsigned8; typedef unsigned short unsigned16; ! typedef unsigned int unsigned32; #ifdef __GNUC__ typedef long long natural64; typedef signed long long signed64; typedef unsigned long long unsigned64; --------------010002020601050807020404--