From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35974 invoked by alias); 27 Feb 2019 18:06:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35790 invoked by uid 89); 27 Feb 2019 18:05:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-type:text, HContent-type:plain X-HELO: ma1-aaemail-dr-lapp01.apple.com Received: from ma1-aaemail-dr-lapp01.apple.com (HELO ma1-aaemail-dr-lapp01.apple.com) (17.171.2.60) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Feb 2019 18:05:57 +0000 Received: from pps.filterd (ma1-aaemail-dr-lapp01.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp01.apple.com (8.16.0.27/8.16.0.27) with SMTP id x1RI1pc8009219; Wed, 27 Feb 2019 10:05:47 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=mime-version : content-transfer-encoding : content-type : sender : subject : from : in-reply-to : date : cc : message-id : references : to; s=20180706; bh=VU1ux5twcN1E4Ub6E9hUtzvCmE+Ta1y5S2okSnazBWg=; b=dE0LUxyD4C0OeziDUKe4wohbo5Fk1dd4UwUD+fpWPvNso99bUn8dt8WwVXJ4RnCVsnTM KJgDjSOaqBUohMfPFUeCtBzhw/Tts9IvAHF0Lw5chek4LMHyqwca5lr8r6ChPtdzxbCo MZTCAE+or7++sKdU6dfO5BUXrbV/DE5oo+i3dZmL5sNb4QOs3kWSYqbrc3bFwKWydFvf LW5vfIeSVQGcpCuLRfWSmTMJEC2kTMahwoRITk36sS6JyNJS0YXf86F/yln7oGLdyoq3 ZNYQpNovjmXoCS4gBj6E93m4v8s78lVwvKmRayP21srBooZLO6AvRuZnm6jL/eSGTH6r Fw== Received: from ma1-mtap-s02.corp.apple.com (ma1-mtap-s02.corp.apple.com [17.40.76.6]) by ma1-aaemail-dr-lapp01.apple.com with ESMTP id 2qu5qca93c-9 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 27 Feb 2019 10:05:47 -0800 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from nwk-mmpp-sz12.apple.com (nwk-mmpp-sz12.apple.com [17.128.115.204]) by ma1-mtap-s02.corp.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPS id <0PNL00JRYJLKLK00@ma1-mtap-s02.corp.apple.com>; Wed, 27 Feb 2019 10:05:46 -0800 (PST) Received: from process_viserion-daemon.nwk-mmpp-sz12.apple.com by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0PNL00000II4CE00@nwk-mmpp-sz12.apple.com>; Wed, 27 Feb 2019 10:05:43 -0800 (PST) X-Va-A: X-Va-T-CD: 49747084b2bec4f811f29a608344864d X-Va-E-CD: 732910c3a4f2b196a36169d164d7535a X-Va-R-CD: c4a43eabb0f7af9d5019705bbc7b4f40 X-Va-CD: 0 X-Va-ID: 783166f7-9bf4-48d8-80c3-f4cc2a48b786 X-V-A: X-V-T-CD: 49747084b2bec4f811f29a608344864d X-V-E-CD: 732910c3a4f2b196a36169d164d7535a X-V-R-CD: c4a43eabb0f7af9d5019705bbc7b4f40 X-V-CD: 0 X-V-ID: 75d291b1-da19-413a-a090-7fd83aa6911d Received: from process_milters-daemon.nwk-mmpp-sz12.apple.com by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0PNL00800JGL5C00@nwk-mmpp-sz12.apple.com>; Wed, 27 Feb 2019 10:05:42 -0800 (PST) Received: from kuribo.apple.com (kuribo.apple.com [17.212.144.216]) by nwk-mmpp-sz12.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPSA id <0PNL00KCKJLI7700@nwk-mmpp-sz12.apple.com>; Wed, 27 Feb 2019 10:05:42 -0800 (PST) Sender: aprantl@apple.com Subject: Re: [PATCH] [dwarf2read] Fix crash when loading dwp files: calculate num_sections based on actual section indices, not just the number of sections. From: Adrian Prantl In-reply-to: Date: Wed, 27 Feb 2019 18:06:00 -0000 Cc: Simon Marchi , Tom Tromey , Jordan Rupprecht , gdb-patches , David Blaikie , Douglas Evans Message-id: <43BCD0FD-28C3-49E5-B7CB-4E18ACFBA646@apple.com> References: <439bf4f6859a539472a2e51a028b9503@polymtl.ca> <20190225201715.144927-1-rupprecht@google.com> <1b6df15638153631ea87fa1bc7c24dd2@polymtl.ca> <87wolmlh8g.fsf@tromey.com> <878sy187tp.fsf@tromey.com> <3c7c4b2b2211dee0d0cb273a2934dde9@polymtl.ca> To: Eric Christopher X-SW-Source: 2019-02/txt/msg00489.txt.bz2 Split DWARF solves a problem that doesn't exist on Darwin (macOS/iOS, ...). The motivation behind split DWARF is to reduce the number of relocations in debug info that have to be processed by the linker. But on Darwin, debug info is not processed by the linker at all, instead a tool called dsymutil (cf. llvm/tools/dsymutil) serves a conceptually similar task to dwp and archives the debug info from the .o files into a .dSYM bundle, separate from the executable. -- adrian > On Feb 27, 2019, at 9:56 AM, Eric Christopher wrote: > > (Adding in Adrian) > > While llvm-dwp will run just fine on osx as a program, it's not > intended for the platform. I don't know if there are any plans for > dwarf5-esque split dwarf on apple platforms. Adrian might be able to > comment more. > > -eric > > On Wed, Feb 27, 2019 at 9:40 AM Simon Marchi wrote: >> >> On 2019-02-27 12:22, Tom Tromey wrote: >>>>>>>> "Simon" == Simon Marchi writes: >>> >>> Simon> So my impression now is that dwp doesn't apply to non-ELF >>> projects. >>> Simon> It is built as part of gold, which itself deals only with ELF, >>> AFAIK. >>> Simon> I tried to build gold on AIX, without success. >>> >>> I think there's also llvm-dwp. Does it work on Mach-O? >>> >>> Tom >> >> Of course, there's llvm-dwp, it's the reason this patch was written :). >> >> Maybe David (in CC) can help answer this? >> >> Simon