From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9706 invoked by alias); 4 Jan 2006 01:49:21 -0000 Received: (qmail 9534 invoked by uid 22791); 4 Jan 2006 01:49:20 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 04 Jan 2006 01:49:19 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k041nHSD016925 for ; Tue, 3 Jan 2006 20:49:17 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k041nF101835; Tue, 3 Jan 2006 20:49:16 -0500 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k041n7sD015782; Tue, 3 Jan 2006 20:49:09 -0500 Message-ID: <43BB297C.5040902@redhat.com> Date: Wed, 04 Jan 2006 01:49:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird (X11/20050322) MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sources.redhat.com, drow@false.org, Eli Zaretskii Subject: Re: [RFA] Linux Checkpoints, take 3 References: <43AC7D2E.6020609@redhat.com> <200512261533.jBQFXCwt001363@elgar.sibelius.xs4all.nl> In-Reply-To: <200512261533.jBQFXCwt001363@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00021.txt.bz2 Anybody object if I consider this approved, once the issues below are taken care of? Mark Kettenis wrote: > Anyway, a few problems that I spotted: > > 1. Please drop the "extern" from _initialize_linux_fork() (and the > associated comment). You'll need an explicit prototype again, like: > > /* Prevent warning from -Wmissing-prototypes. */ > void _initialize_linux_fork (void); > > 2. Please update the copyright notice to use (C) and the new FSF > address. > > 3. Replace the FORKS_EXISTS() macro with a forks_exists_p() function? > Or inline it if you don't think it's ever going to be changed. > > 4. Aren't the values used for SEEK_SET/SEEK_CUR the same on all Linux > ports? In that case perhaps #defining LINUX_SEEK_SET 0, and using > LINUX_SEEK_SET would be a good solution. > > 5. Could you seperate out the "Detaching after fork from child > process" printing? > > And from the nitpicking department: > > 1. The comments on the #includes are a bit silly. I'd rather not see > any unless there's something really unobvious going on. They get > out of data pretty soon anyway. > > 2. Please don't put the function name in comments above the function. > (call_lseek, linux_fork_killall, linux_fork_mourn_inferior, > > 3. Really sorry to hear that you're suffering from a split personality > problem: > > >>2005-12-19 Michael Snyder >> >>2005-12-19 Michael Van Meter Snyder >> > > Otherwise, I think it's ok. It's a bit sad that this is a Linux-only > implementation, but then it's mostly Linux-specific code. I'll see if > I can rig up something for OpenBSD, and then we can sort out what bits > are target-independent. > > Mark >