From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21657 invoked by alias); 29 Dec 2005 13:41:30 -0000 Received: (qmail 21524 invoked by uid 22791); 29 Dec 2005 13:41:29 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.199) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 29 Dec 2005 13:41:27 +0000 Received: by zproxy.gmail.com with SMTP id l1so1813300nzf for ; Thu, 29 Dec 2005 05:41:25 -0800 (PST) Received: by 10.36.18.17 with SMTP id 17mr6651008nzr; Thu, 29 Dec 2005 05:41:25 -0800 (PST) Received: from ?192.168.0.124? ( [218.1.150.9]) by mx.gmail.com with ESMTP id 38sm11257911nzk.2005.12.29.05.41.22; Thu, 29 Dec 2005 05:41:24 -0800 (PST) Message-ID: <43B3E771.9000705@gmail.com> Date: Sat, 31 Dec 2005 05:46:00 -0000 From: Jie Zhang User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051010) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, Daniel Jacobowitz Subject: [PATCH] Fix a small bug in gdbserver Content-Type: multipart/mixed; boundary="------------050204040200090908060906" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00314.txt.bz2 This is a multi-part message in MIME format. --------------050204040200090908060906 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 143 Hi, This patch will make gdbserver search through the whole breakpoint list when it's finding the being deleted one. Is it OK? Thanks, Jie --------------050204040200090908060906 Content-Type: text/x-patch; name="gdbserver-delete-breakpoint.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdbserver-delete-breakpoint.diff" Content-length: 1049 2005-12-29 Jie Zhang * mem-break.c (delete_breakpoint): Search through the whole breakpoint list for the being deleted one. Index: mem-break.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/mem-break.c,v retrieving revision 1.5 diff -u -p -r1.5 mem-break.c --- mem-break.c 23 Dec 2005 18:11:55 -0000 1.5 +++ mem-break.c 29 Dec 2005 13:16:47 -0000 @@ -84,18 +84,15 @@ delete_breakpoint (struct breakpoint *bp free (bp); return; } - cur = breakpoints; - while (cur->next) - { - if (cur->next == bp) - { - cur->next = bp->next; - (*the_target->write_memory) (bp->pc, bp->old_data, - breakpoint_len); - free (bp); - return; - } - } + for (cur = breakpoints; cur->next; cur = cur->next) + if (cur->next == bp) + { + cur->next = bp->next; + (*the_target->write_memory) (bp->pc, bp->old_data, + breakpoint_len); + free (bp); + return; + } warning ("Could not find breakpoint in list."); } --------------050204040200090908060906--