From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68774-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3356 invoked by alias); 7 Dec 2009 09:54:16 -0000
Received: (qmail 3348 invoked by uid 22791); 7 Dec 2009 09:54:16 -0000
X-SWARE-Spam-Status: No, hits=0.4 required=5.0 	tests=AWL,BAYES_00,KAM_STOCKTIP
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Dec 2009 09:54:13 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 24CB2290016; 	Mon,  7 Dec 2009 10:54:11 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1]) 	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id XHTE0y21oaPK; Mon,  7 Dec 2009 10:54:10 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) 	(using TLSv1 with cipher AES128-SHA (128/128 bits)) 	(No client certificate requested) 	by mel.act-europe.fr (Postfix) with ESMTP id 83FD1290014; 	Mon,  7 Dec 2009 10:54:10 +0100 (CET)
Subject: Re: [RFA] Pass all symfile flags to sym_read.
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m3d42ufzdk.fsf@fleche.redhat.com>
Date: Mon, 07 Dec 2009 09:54:00 -0000
Cc: gdb-patches@sourceware.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <43A0DBB9-4383-47E7-B6B1-98A4861A90D5@adacore.com>
References: <20091204124327.GA5714@ulanbator.act-europe.fr> <m3d42ufzdk.fsf@fleche.redhat.com>
To: tromey@redhat.com
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00072.txt.bz2


On Dec 4, 2009, at 6:00 PM, Tom Tromey wrote:

>>>>>> "Tristan" =3D=3D Tristan Gingold <gingold@adacore.com> writes:
>=20
> Tristan> 2009-12-02  Tristan Gingold  <gingold@adacore.com>
> Tristan> 	* symfile.h (struct sym_fns): Adjust comment on sym_read.
> Tristan> 	* symfile.c (syms_from_objfile): Pass all symfile flags to sym_=
read.
> Tristan> 	* dbxread.c (dbx_symfile_read): Rename mainline to symfile_flag=
s,
> Tristan> 	adjust header comment.
> Tristan> 	* elfread.c (elf_symfile_read): Ditto.
> Tristan> 	* somread.c (som_symfile_read): Ditto.
> Tristan> 	* xcoffread.c (xcoff_initial_scan): Ditto.
> Tristan> 	* coffread.c (coff_symfile_read): Rename mainline to symfile_fl=
ags.
> Tristan> 	* machoread.c (macho_symfile_read): Ditto.
> Tristan> 	* mipsread.c (mipscoff_symfile_read): Ditto.
>=20
> This is ok with one little nit fixed...
>=20
> Tristan> diff --git a/gdb/symfile.h b/gdb/symfile.h
> [...]
> Tristan> +     file we are reading.  SYMFILE_FLAGS are the flags passed to
> Tristan> +     symbol_fil_add & co.  */
>=20
> ... typo in "symbol_file_add".

Thank you for catching that.
Committed with the typo fix.

Tristan.