Eli Zaretskii wrote: > Okay for the breakpoint.c patch, thanks. I have only one comment: > please remove all the "The" articles before argument names, like this: > > +LOCATION may be a line number, function name, or \"*\" and an address.\n\ > > instead of > > +The LOCATION may be a line number, function name, or \"*\" and an address.\n\ > > Also, can I ask you for a small favor? There are other *break and > similar commands defined in breakpoint.c, whose doc strings reference > those of other commands and eventually the one you fixed. I never > liked those references: the user shouldn't need to look up several > commands she doesn't care about to arrive at the required info. So > could you please modify all those other doc strings to simply repeat > the arguments' description you just fixed? How about the attached? I have broken out the common parts into a macro to prevent duplication and hopefully make future maintenance easier. I have tested gdb.base/help.exp and all is well. Andrew