From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 701 invoked by alias); 2 Dec 2005 10:44:42 -0000 Received: (qmail 689 invoked by uid 22791); 2 Dec 2005 10:44:40 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-04.spheriq.net (HELO lon-del-04.spheriq.net) (195.46.50.101) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Dec 2005 10:44:38 +0000 Received: from lon-out-03.spheriq.net ([195.46.50.131]) by lon-del-04.spheriq.net with ESMTP id jB2AiaDZ007356 for ; Fri, 2 Dec 2005 10:44:36 GMT Received: from lon-cus-02.spheriq.net (lon-cus-02.spheriq.net [195.46.50.38]) by lon-out-03.spheriq.net with ESMTP id jB2AiXWZ021608 for ; Fri, 2 Dec 2005 10:44:35 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-02.spheriq.net with ESMTP id jB2AiOfX011355 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 2 Dec 2005 10:44:26 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BFA00DA5E; Fri, 2 Dec 2005 10:44:11 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id DB68A47362; Fri, 2 Dec 2005 10:47:09 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 49BE475994; Fri, 2 Dec 2005 10:47:09 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A548647362; Fri, 2 Dec 2005 10:47:08 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHA53858 (AUTH "andrew stubbs"); Fri, 2 Dec 2005 10:44:01 GMT Message-ID: <439024E8.9050206@st.com> Date: Fri, 02 Dec 2005 11:18:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) MIME-Version: 1.0 To: Eli Zaretskii Cc: jimb@red-bean.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] init-if-undefined command References: <437B3E56.3080306@st.com> <8f2776cb0511292141t2f9711a2l9633236db737e67b@mail.gmail.com> <438DB351.2050500@st.com> <20051130190311.GA25377@nevyn.them.org> <8f2776cb0511301501t4eb7bb50w484427fd892f5a58@mail.gmail.com> <438EE3F8.70103@st.com> <438F3327.8080802@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00044.txt.bz2 Eli Zaretskii wrote: > Your mailer seems to be wrapping lines. Normally I attach them to avoid wrapping, but this time I cut-n-paste it into the body because I didn't want to post all the code again. > Anyway, I'd suggest a slightly different text: > > init-if-undefined Initialize a convenience variable, but > only if it doesn't already have a value. > > (This is more clear than the vague ``if necessary'', IMHO.) > > WDYT? > That's fine by me. I'll put it in as you say. Thanks Andrew