From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 44aAEKjzH2YYqTIAWB0awg (envelope-from ) for ; Wed, 17 Apr 2024 12:07:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 3016B1E0C0; Wed, 17 Apr 2024 12:07:04 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C2D51E092 for ; Wed, 17 Apr 2024 12:07:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82A853858D20 for ; Wed, 17 Apr 2024 16:07:01 +0000 (GMT) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id 89AB63858D20 for ; Wed, 17 Apr 2024 16:06:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89AB63858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 89AB63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713370005; cv=none; b=FRj09iVvcDV0ff9d4www69n3XKZZmYxHWnTLye4lGjHTvUwNr2RhBMsRW053Gy0tDO7XapabBTmm8yFtfuEJ+1S7JVXmTJ7/e9qBXYq3gdQKManim5iuqwdPNWHuBC113sUXmdbgVZNmjWEZHnRFVG++d9uiUJ+F1A9okY0bDtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713370005; c=relaxed/simple; bh=WZevlGRcD78jB0lQ2HoZ3tmqQS+CMXJ2b5JwKSHrvm4=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=jlcbx3hlZH8l1gTshe6YazY0I1A4i6KiHuV4ZwQeh+TnKCfuzq3tMYNpVBV0N7DyDRGxwnjJNG6M5Ksi0VvHPcVzm61gOpNBxZ90o9gsJjw/OATubdoBrqxsxJXyb4NSw0RN939YHJdavNbsFZvHCXAFnGJM2vlpN6C7HW3/t68= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-349caee176bso487977f8f.2 for ; Wed, 17 Apr 2024 09:06:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713370001; x=1713974801; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bP2Xyn+VMVZVSjJ0N5nbtgrrlJFafAUr5fgc5t4l3eM=; b=gb0zRB2PIHpFPCxtCM+v8lgTxGD9+rHOJjozP1LoB440lu4434iv6VDe0z06wJg6CF aEd1DUR+HNFA7XAkdt3W22LkZagh5YIoJR2zfqBGMbUfTi0NTkcdAlkFHcGgExg47/dJ UGxlB1C+eWoYPfyxB31YhJjuxrWXCAjp4vaYYwFnFCcXlw+4DATMhCYwqbQQB63Ow9TY 4MnMvtaIN8NNZI4rQrp2BiyXHPdFtlkcWz3Y29GAUo4mUp9sm5oXOBURuJ7j0qQStRga rg0XqCcdaz0zHsSVcCUCE+Nr5yeh4pQ55kHRJyRhHT5pJChZYv/uH0T0JkKbLgn87wio SBQA== X-Forwarded-Encrypted: i=1; AJvYcCXiGiBhLTeteBnLCYjNDt4o4aD8cBdbnm8WCyByjHxRORx2bsjaoxCtIawrLTwslTxGQbyA4XyZuvx53VnI8n1H3b2TZe489CAVuQ== X-Gm-Message-State: AOJu0YxKlHsnlEFMMHnT9WkADO/+mpnPuipYApf8i3Y5PkLAg6ysMLDf qG5XcuZVojaqLefwL7gr+4Smc/fiMbNatJVI+vbaRuQVuxYzjl6kK05QOEqP X-Google-Smtp-Source: AGHT+IFPVo/jDpuBbNGYzCTHaX327x0V/UeGtn9RfqZBCobqYPCHq22qY+ZfHvEjj+Nnhep+R2zAKw== X-Received: by 2002:a5d:4411:0:b0:349:8a92:7eda with SMTP id z17-20020a5d4411000000b003498a927edamr3163403wrq.12.1713370000938; Wed, 17 Apr 2024 09:06:40 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:e643:3adf:640c:b3ad? ([2001:8a0:f93d:b900:e643:3adf:640c:b3ad]) by smtp.gmail.com with ESMTPSA id d5-20020adfc805000000b00349bd105089sm1993861wrh.47.2024.04.17.09.06.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 09:06:40 -0700 (PDT) Message-ID: <438f6f8f-ff05-464f-a63e-bdd2384fa371@palves.net> Date: Wed, 17 Apr 2024 17:06:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/3] gdb/nat: Factor linux_find_proc_stat_field out of linux_common_core_of_thread To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20240321231149.519549-1-thiago.bauermann@linaro.org> <20240321231149.519549-3-thiago.bauermann@linaro.org> From: Pedro Alves Content-Language: en-US In-Reply-To: <20240321231149.519549-3-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-03-21 23:11, Thiago Jung Bauermann wrote: > The new function will be used in a subsequent patch to read a different > stat field. > > The new code is believed to be equivalent to the old code, so there should > be no change in GDB behaviour. > > Also, take the opportunity to move the function's documentation comment to > the header file, to conform with GDB practice. IMO, it'd be even better to move the new function to linux-proc.c, with a linux_proc prefix.