From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9448 invoked by alias); 1 Dec 2005 16:57:40 -0000 Received: (qmail 9438 invoked by uid 22791); 1 Dec 2005 16:57:39 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-02.spheriq.net (HELO lon-del-02.spheriq.net) (195.46.50.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Dec 2005 16:57:32 +0000 Received: from lon-out-01.spheriq.net ([195.46.50.129]) by lon-del-02.spheriq.net with ESMTP id jB1GvNlB025268 for ; Thu, 1 Dec 2005 16:57:26 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-01.spheriq.net with ESMTP id jB1GvNDm008298 for ; Thu, 1 Dec 2005 16:57:23 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id jB1GvMjn014464 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK) for ; Thu, 1 Dec 2005 16:57:23 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 732CADA46 for ; Thu, 1 Dec 2005 16:57:21 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id B9C9E47594; Thu, 1 Dec 2005 16:59:54 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7137D75994 for ; Thu, 1 Dec 2005 16:59:54 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E9F8047524 for ; Thu, 1 Dec 2005 16:59:53 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHA48481 (AUTH "andrew stubbs"); Thu, 1 Dec 2005 16:56:47 GMT Message-ID: <438F2AC7.7070505@st.com> Date: Thu, 01 Dec 2005 16:57:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Enhance break command help References: <438EEBC5.8040802@st.com> In-Reply-To: <438EEBC5.8040802@st.com> Content-Type: multipart/mixed; boundary="------------050908060201090202000607" X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00019.txt.bz2 This is a multi-part message in MIME format. --------------050908060201090202000607 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 300 Andrew Stubbs wrote: > The attached patch adds more information to the on-line help for the > break command. It adds a brief description how to set thread specific > and conditional breakpoints. I forgot to update the testsuite to expect the new help text. Updated patch attached. Andrew Stubbs --------------050908060201090202000607 Content-Type: text/plain; name="break-help.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="break-help.patch" Content-length: 13176 2005-12-01 Andrew Stubbs * breakpoint.c (_initialize_breakpoint): Enhance break command help. testsuite/ * gdb.base/help.exp (help b, help br, help bre, help brea) (help break): Update the expected message. Index: src/gdb/breakpoint.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src.orig/gdb/breakpoint.c 2005-12-01 12:05:59.000000000 +0000 +++ src/gdb/breakpoint.c 2005-12-01 12:19:28.000000000 +0000 @@ -7809,13 +7809,17 @@ See also the \"delete\" command which cl =20 c =3D add_com ("break", class_breakpoint, break_command, _("\ Set breakpoint at specified line or function.\n\ -Argument may be line number, function name, or \"*\" and an address.\n\ -If line number is specified, break at start of code for that line.\n\ -If function is specified, break at start of code for that function.\n\ +break [LOCATION] [thread THREADNUM] [if CONDITION]\n\ +The LOCATION may be a line number, function name, or \"*\" and an address.= \n\ +If a line number is specified, break at start of code for that line.\n\ +If a function is specified, break at start of code for that function.\n\ If an address is specified, break at that exact address.\n\ -With no arg, uses current execution address of selected stack frame.\n\ +With no LOCATION, uses current execution address of selected stack frame.\= n\ This is useful for breaking on return to a stack frame.\n\ \n\ +The THREADNUM is the number from \"info threads\".\n\ +The CONDITION is a boolean expression.\n\ +\n\ Multiple breakpoints at one place are permitted, and useful if conditional= .\n\ \n\ Do \"help breakpoints\" for info on other commands dealing with breakpoint= s.")); Index: src/gdb/testsuite/gdb.base/help.exp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src.orig/gdb/testsuite/gdb.base/help.exp 2005-12-01 12:05:57.000000000 = +0000 +++ src/gdb/testsuite/gdb.base/help.exp 2005-12-01 16:30:05.000000000 +0000 @@ -50,15 +50,15 @@ gdb_test "help append binary value" "App # test help attach gdb_test "help attach" "Attach to a process or file outside of GDB\.\[\r\n= \]+This command attaches to another target, of the same type as your last\[= \r\n\]+\"target\" command \\(\"info files\" will show your target stack\\)\= .\[\r\n\]+The command may take as argument a process id or a device file\.\= [\r\n\]+For a process id, you must have permission to send the process a si= gnal,\[\r\n\]+and it must have the same effective uid as the debugger\.\[\r= \n\]+When using \"attach\" with a process id, the debugger finds the\[\r\n\= ]+program running in the process, looking first in the current working\[\r\= n\]+directory, or \\(if not found there\\) using the source file search pat= h\[\r\n\]+\\(see the \"directory\" command\\)\. You can also use the \"fil= e\" command\[\r\n\]+to specify the program, and to load its symbol table\."= "help attach" # test help breakpoint "b" abbreviation -gdb_test "help b" "Set breakpoint at specified line or function\.\[\r\n\]+= Argument may be line number, function name, or \"\[*\]\" and an address\.\[= \r\n\]+If line number is specified, break at start of code for that line\.\= [\r\n\]+If function is specified, break at start of code for that function\= .\[\r\n\]+If an address is specified, break at that exact address\.\[\r\n\]= +With no arg, uses current execution address of selected stack frame\.\[\r\= n\]+This is useful for breaking on return to a stack frame\.\[\r\n\]+Multip= le breakpoints at one place are permitted, and useful if conditional\.\[\r\= n\]+Do \"help breakpoints\" for info on other commands dealing with breakpo= ints\." "help breakpoint \"b\" abbreviation" +gdb_test "help b" "Set breakpoint at specified line or function\.\[\r\n\]+= break \\\[LOCATION\] \\\[thread THREADNUM\] \\\[if CONDITION\]\[\r\n\]+The = LOCATION may be a line number, function name, or \"\[*\]\" and an address\.= \[\r\n\]+If a line number is specified, break at start of code for that lin= e\.\[\r\n\]+If a function is specified, break at start of code for that fun= ction\.\[\r\n\]+If an address is specified, break at that exact address\.\[= \r\n\]+With no LOCATION, uses current execution address of selected stack f= rame\.\[\r\n\]+This is useful for breaking on return to a stack frame\.\[\r= \n\]+The THREADNUM is the number from \"info threads\"\.\[\r\n\]+The CONDIT= ION is a boolean expression\.\[\r\n\]+Multiple breakpoints at one place are= permitted, and useful if conditional\.\[\r\n\]+Do \"help breakpoints\" for= info on other commands dealing with breakpoints\." "help breakpoint \"b\" = abbreviation" # test help breakpoint "br" abbreviation -gdb_test "help br" "Set breakpoint at specified line or function\.\[\r\n\]= +Argument may be line number, function name, or \"\[*\]\" and an address\.\= [\r\n\]+If line number is specified, break at start of code for that line\.= \[\r\n\]+If function is specified, break at start of code for that function= \.\[\r\n\]+If an address is specified, break at that exact address\.\[\r\n\= ]+With no arg, uses current execution address of selected stack frame\.\[\r= \n\]+This is useful for breaking on return to a stack frame\.\[\r\n\]+Multi= ple breakpoints at one place are permitted, and useful if conditional\.\[\r= \n\]+Do \"help breakpoints\" for info on other commands dealing with breakp= oints\." "help breakpoint \"br\" abbreviation" +gdb_test "help br" "Set breakpoint at specified line or function\.\[\r\n\]= +break \\\[LOCATION\] \\\[thread THREADNUM\] \\\[if CONDITION\]\[\r\n\]+The= LOCATION may be a line number, function name, or \"\[*\]\" and an address\= .\[\r\n\]+If a line number is specified, break at start of code for that li= ne\.\[\r\n\]+If a function is specified, break at start of code for that fu= nction\.\[\r\n\]+If an address is specified, break at that exact address\.\= [\r\n\]+With no LOCATION, uses current execution address of selected stack = frame\.\[\r\n\]+This is useful for breaking on return to a stack frame\.\[\= r\n\]+The THREADNUM is the number from \"info threads\"\.\[\r\n\]+The CONDI= TION is a boolean expression\.\[\r\n\]+Multiple breakpoints at one place ar= e permitted, and useful if conditional\.\[\r\n\]+Do \"help breakpoints\" fo= r info on other commands dealing with breakpoints\." "help breakpoint \"br\= " abbreviation" # test help breakpoint "bre" abbreviation -gdb_test "help bre" "Set breakpoint at specified line or function\.\[\r\n\= ]+Argument may be line number, function name, or \"\[*\]\" and an address\.= \[\r\n\]+If line number is specified, break at start of code for that line\= .\[\r\n\]+If function is specified, break at start of code for that functio= n\.\[\r\n\]+If an address is specified, break at that exact address\.\[\r\n= \]+With no arg, uses current execution address of selected stack frame\.\[\= r\n\]+This is useful for breaking on return to a stack frame\.\[\r\n\]+Mult= iple breakpoints at one place are permitted, and useful if conditional\.\[\= r\n\]+Do \"help breakpoints\" for info on other commands dealing with break= points\." "help breakpoint \"bre\" abbreviation" +gdb_test "help bre" "Set breakpoint at specified line or function\.\[\r\n\= ]+break \\\[LOCATION\] \\\[thread THREADNUM\] \\\[if CONDITION\]\[\r\n\]+Th= e LOCATION may be a line number, function name, or \"\[*\]\" and an address= \.\[\r\n\]+If a line number is specified, break at start of code for that l= ine\.\[\r\n\]+If a function is specified, break at start of code for that f= unction\.\[\r\n\]+If an address is specified, break at that exact address\.= \[\r\n\]+With no LOCATION, uses current execution address of selected stack= frame\.\[\r\n\]+This is useful for breaking on return to a stack frame\.\[= \r\n\]+The THREADNUM is the number from \"info threads\"\.\[\r\n\]+The COND= ITION is a boolean expression\.\[\r\n\]+Multiple breakpoints at one place a= re permitted, and useful if conditional\.\[\r\n\]+Do \"help breakpoints\" f= or info on other commands dealing with breakpoints\." "help breakpoint \"br= e\" abbreviation" # test help breakpoint "brea" abbreviation -gdb_test "help brea" "Set breakpoint at specified line or function\.\[\r\n= \]+Argument may be line number, function name, or \"\[*\]\" and an address\= .\[\r\n\]+If line number is specified, break at start of code for that line= \.\[\r\n\]+If function is specified, break at start of code for that functi= on\.\[\r\n\]+If an address is specified, break at that exact address\.\[\r\= n\]+With no arg, uses current execution address of selected stack frame\.\[= \r\n\]+This is useful for breaking on return to a stack frame\.\[\r\n\]+Mul= tiple breakpoints at one place are permitted, and useful if conditional\.\[= \r\n\]+Do \"help breakpoints\" for info on other commands dealing with brea= kpoints\." "help breakpoint \"brea\" abbreviation" +gdb_test "help brea" "Set breakpoint at specified line or function\.\[\r\n= \]+break \\\[LOCATION\] \\\[thread THREADNUM\] \\\[if CONDITION\]\[\r\n\]+T= he LOCATION may be a line number, function name, or \"\[*\]\" and an addres= s\.\[\r\n\]+If a line number is specified, break at start of code for that = line\.\[\r\n\]+If a function is specified, break at start of code for that = function\.\[\r\n\]+If an address is specified, break at that exact address\= .\[\r\n\]+With no LOCATION, uses current execution address of selected stac= k frame\.\[\r\n\]+This is useful for breaking on return to a stack frame\.\= [\r\n\]+The THREADNUM is the number from \"info threads\"\.\[\r\n\]+The CON= DITION is a boolean expression\.\[\r\n\]+Multiple breakpoints at one place = are permitted, and useful if conditional\.\[\r\n\]+Do \"help breakpoints\" = for info on other commands dealing with breakpoints\." "help breakpoint \"b= rea\" abbreviation" # test help breakpoint "break" abbreviation -gdb_test "help break" "Set breakpoint at specified line or function\.\[\r\= n\]+Argument may be line number, function name, or \"\[*\]\" and an address= \.\[\r\n\]+If line number is specified, break at start of code for that lin= e\.\[\r\n\]+If function is specified, break at start of code for that funct= ion\.\[\r\n\]+If an address is specified, break at that exact address\.\[\r= \n\]+With no arg, uses current execution address of selected stack frame\.\= [\r\n\]+This is useful for breaking on return to a stack frame\.\[\r\n\]+Mu= ltiple breakpoints at one place are permitted, and useful if conditional\.\= [\r\n\]+Do \"help breakpoints\" for info on other commands dealing with bre= akpoints\." "help breakpoint \"break\" abbreviation" +gdb_test "help break" "Set breakpoint at specified line or function\.\[\r\= n\]+break \\\[LOCATION\] \\\[thread THREADNUM\] \\\[if CONDITION\]\[\r\n\]+= The LOCATION may be a line number, function name, or \"\[*\]\" and an addre= ss\.\[\r\n\]+If a line number is specified, break at start of code for that= line\.\[\r\n\]+If a function is specified, break at start of code for that= function\.\[\r\n\]+If an address is specified, break at that exact address= \.\[\r\n\]+With no LOCATION, uses current execution address of selected sta= ck frame\.\[\r\n\]+This is useful for breaking on return to a stack frame\.= \[\r\n\]+The THREADNUM is the number from \"info threads\"\.\[\r\n\]+The CO= NDITION is a boolean expression\.\[\r\n\]+Multiple breakpoints at one place= are permitted, and useful if conditional\.\[\r\n\]+Do \"help breakpoints\"= for info on other commands dealing with breakpoints\." "help breakpoint \"= break\" abbreviation" # test help breakpoints gdb_test "help breakpoints" "Making program stop at certain points\.\[\r\n= \]+List of commands:\[\r\n\]+awatch -- Set a watchpoint for an expression\[= \r\n\]+break -- Set breakpoint at specified line or function\[\r\n\]+catch = -- Set catchpoints to catch events\[\r\n\]+clear -- Clear breakpoint at spe= cified line or function\[\r\n\]+commands -- Set commands to be executed whe= n a breakpoint is hit\[\r\n\]+condition -- Specify breakpoint number N to b= reak only if COND is true\[\r\n\]+delete -- Delete some breakpoints or auto= -display expressions\[\r\n\]+disable -- Disable some breakpoints\[\r\n\]+en= able -- Enable some breakpoints\[\r\n\]+hbreak -- Set a hardware assisted = breakpoint\[\r\n\]+ignore -- Set ignore-count of breakpoint number N to COU= NT\[\r\n\]+rbreak -- Set a breakpoint for all functions matching REGEXP\[\r= \n\]+rwatch -- Set a read watchpoint for an expression\[\r\n\]+tbreak -- Se= t a temporary breakpoint\[\r\n\]+tcatch -- Set temporary catchpoints to cat= ch events\[\r\n\]+thbreak -- Set a temporary hardware assisted breakpoint\[= \r\n\]+watch -- Set a watchpoint for an expression\[\r\n\]+Type \"help\" fo= llowed by command name for full documentation\.\[\r\n\]+Command name abbrev= iations are allowed if unambiguous\." "help breakpoints" # test help backtrace "bt" abbreviation --------------050908060201090202000607--