Re: PATCH: Use target values for signals in simulator

Hans-Peter Nilsson
2005-11-29T02:34:48Z

On Mon, 28 Nov 2005, Mark Mitchell wrote:

> Daniel Jacobowitz wrote:
>
> > OK with that change.
>
> Here's the version I checked in, for the record.

(Sent as attachment, so I can't quote in pine...)

Something went generally wrong.

For cris-elf, I see (cutnpaste):
gcc -c
/home/hp/combined/combined/sim/cris/../common/sim-signal.c
-DHAVE_CONFIG_H -DWITH_DEFAULT_MODEL='"crisv32"' -DPROFILE=1\
-DWITH_PROFILE=-1 -DWITH_ALIGNMENT=NONSTRICT_ALIGNMENT
-DWITH_ENVIRONMENT=ALL_ENVIRONMENT
-DWITH_HOST_BYTE_ORDER=LITTLE_EN\
DIAN -DWITH_SCACHE=16384 -I.
-I/home/hp/combined/combined/sim/cris -I../common
-I/home/hp/combined/combined/sim/cris\
/../common -I../../include
-I/home/hp/combined/combined/sim/cris/../../include -I../../bfd
-I/home/hp/combined/combined/sim/cris/\
../../bfd -I../../opcodes
-I/home/hp/combined/combined/sim/cris/../../opcodes -I../../intl
-I/home/hp/combined/combined/sim/cris/\
../../intl -g -O2
/home/hp/combined/combined/sim/common/sim-signal.c:100: error: conflicting types for `sim_signal_to_target'
/home/hp/combined/combined/sim/common/sim-signal.h:50: error: previous declaration of `sim_signal_to_target'
/home/hp/combined/combined/sim/common/sim-signal.c: In function `sim_signal_to_target':
/home/hp/combined/combined/sim/common/sim-signal.c:119: error: syntax error before "return"
make[5]: *** [sim-signal.o] Error 1

To wit:
sim-signal.h:
enum target_signal sim_signal_to_target (SIM_DESC sd, SIM_SIGNAL);

sim-signal.c:
int
sim_signal_to_target (SIM_DESC sd, SIM_SIGNAL sig)

I guess you attached and committed the wrong version. There's
an obvious syntax error; missing ":" on one case line, see
above.

brgds, H-P