From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31887 invoked by alias); 25 Nov 2005 18:11:08 -0000 Received: (qmail 31879 invoked by uid 22791); 25 Nov 2005 18:11:07 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-04.spheriq.net (HELO fra-del-04.spheriq.net) (195.46.51.100) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Nov 2005 18:11:03 +0000 Received: from fra-out-02.spheriq.net (fra-out-02.spheriq.net [195.46.51.130]) by fra-del-04.spheriq.net with ESMTP id jAPIAxZV029444 for ; Fri, 25 Nov 2005 18:10:59 GMT Received: from fra-cus-02.spheriq.net (fra-cus-02.spheriq.net [195.46.51.38]) by fra-out-02.spheriq.net with ESMTP id jAPIAvDZ011127 for ; Fri, 25 Nov 2005 18:10:58 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-02.spheriq.net with ESMTP id jAPIAukh001157 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 25 Nov 2005 18:10:56 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id EC1E4DA41; Fri, 25 Nov 2005 18:10:55 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id 8E43F4751E; Fri, 25 Nov 2005 18:13:58 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4E7A575995; Fri, 25 Nov 2005 18:13:58 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B5B01473DD; Fri, 25 Nov 2005 18:13:57 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CHA04841 (AUTH "andrew stubbs"); Fri, 25 Nov 2005 18:10:53 GMT Message-ID: <438752FE.9070302@st.com> Date: Fri, 25 Nov 2005 18:33:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Use search path for scripts References: <437B6718.7070300@st.com> <437C6D69.1030209@st.com> <437DC94B.7060601@st.com> <437DE8F9.9030606@st.com> <20051125175735.GB736@nevyn.them.org> In-Reply-To: <20051125175735.GB736@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00462.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Nov 18, 2005 at 02:45:13PM +0000, Andrew STUBBS wrote: > >> * cli-cmds.c: Include fcntl.h. >> (source_command): Use the GDB search path to find script files. >> >>doc/ >> * gdb.texinfo (Choosing files): Mention that -directory is used >> for script files. >> (Specifying source directories): Likewise. >> (Command files): Explain how script files are found. > > > Could you explain why you used the source path to search for scripts, > instead of a separate search path? Was it just because it was handy? > Are scripts likely to be in manually-added directories on the source > search path? > > I don't see the correspondence. Because it was handy, but who says it is the 'source search path'? It's just that that's all it's been used for up till now. The source directory is as likely a place as any for script files (perhaps with some commands to help visualise the data). As it happens we *always* add a directory (via -d in a wrapper) which contains nothing but scripts, but since there are no sources that causes no problems. Conversely, there's no technical reason why they couldn't have different search paths. However, having more may lead to confusion, command/option bloat, and the possibility that the user will have to add the same path twice - once to each path. If you wish I can split it out into a new list, with new commands, new command-line options and new documentation. It solves the same problems in the end. Thanks Andrew Stubbs