From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1005 invoked by alias); 23 Nov 2005 15:59:20 -0000 Received: (qmail 997 invoked by uid 22791); 23 Nov 2005 15:59:19 -0000 X-Spam-Check-By: sourceware.org Received: from lon-del-04.spheriq.net (HELO lon-del-04.spheriq.net) (195.46.50.101) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Nov 2005 15:59:17 +0000 Received: from lon-out-01.spheriq.net ([195.46.50.129]) by lon-del-04.spheriq.net with ESMTP id jANFxDHv027581 for ; Wed, 23 Nov 2005 15:59:13 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-01.spheriq.net with ESMTP id jANFxBAo003301 for ; Wed, 23 Nov 2005 15:59:12 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id jANFx7Qa002701 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Wed, 23 Nov 2005 15:59:11 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6D1BDDA4C; Wed, 23 Nov 2005 15:59:01 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id D875A4745F; Wed, 23 Nov 2005 16:02:02 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0A3AF75995; Wed, 23 Nov 2005 16:02:01 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 311C04745A; Wed, 23 Nov 2005 16:02:01 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CGZ86665 (AUTH "andrew stubbs"); Wed, 23 Nov 2005 15:58:57 GMT Message-ID: <43849117.5030805@st.com> Date: Wed, 23 Nov 2005 18:58:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Andreas Schwab Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix 'Undefined command' error message References: <4379EC0A.3060601@st.com> <20051116201300.GA23472@nevyn.them.org> <4382072A.1010402@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.2.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00433.txt.bz2 Andreas Schwab wrote: > Andrew STUBBS writes: > >>The XDB characters clash with existing GDB commands so I have left those >>disabled unless in XDB mode. Specifically commands such as 'x/i' fail >>because the command there is actually only 'x'. Obviously this does not >>affect commands such as 'x /i'. > > The same clash exists with '+'. Things like "u+1" won't work any more, > IIUC. Hmmm, this looks more like a parser exploit than a feature. Either that or the TUI can be considered broken. Should I leave these characters as TUI only or always allow them? Does anybody have a strong opinion either way? I would tend to favour leaving it as is. Andrew