From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25869 invoked by alias); 17 Nov 2005 10:04:50 -0000 Received: (qmail 25727 invoked by uid 22791); 17 Nov 2005 10:04:47 -0000 Received: from ip127.bb146.pacific.net.hk (HELO stl.com.hk) (202.64.146.127) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 17 Nov 2005 10:04:47 +0000 Received: from rccomp.stl.com.hk ([192.168.100.200]) by stl.com.hk with esmtp (Exim 4.50) id 1EcgZT-0007RK-0c; Thu, 17 Nov 2005 18:00:47 +0800 Message-ID: <437C55B8.1070604@tausq.org> Date: Thu, 17 Nov 2005 12:10:00 -0000 From: Randolph Chung User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050805) MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sources.redhat.com Subject: Re: [hppa-hpux] Signal frame unwinding support for hppa64-hp-hpux11.11 References: <437C0B76.7010109@tausq.org> <200511170956.jAH9uXfn030506@elgar.sibelius.xs4all.nl> In-Reply-To: <200511170956.jAH9uXfn030506@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00270.txt.bz2 >>2005-11-15 Randolph Chung >> >> * hppa-hpux-tdep.c (hppa_hpux_sigtramp_frame_unwind_cache): Ensure "off" >> is large enough to hold 64-bit offset. Set proper signal context offset >> for 64-bit programs. Set pc properly for signal frames. > > > Please reformat the ChangeLog entry before you commit; the lines are too long! I can, but these lines are only 80 characters wide... why are they too long? >>Index: hppa-hpux-tdep.c >>=================================================================== >>RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v >>retrieving revision 1.43 >>diff -u -p -r1.43 hppa-hpux-tdep.c >>--- hppa-hpux-tdep.c 29 Oct 2005 21:31:45 -0000 1.43 >>+++ hppa-hpux-tdep.c 15 Nov 2005 15:40:07 -0000 >>@@ -1188,7 +1192,7 @@ hppa_hpux_sigtramp_frame_unwind_cache (s >> else >> { >> /* Wide registers. */ >>- off = scptr + offsetof (save_state_t, ss_wide) + 8; >>+ off = scptr + offsetof (save_state_t, ss_wide.ss_64) + 8; >> incr = 8; >> szoff = (tdep->bytes_per_address == 4 ? 4 : 0); >> } >>@@ -1203,11 +1207,15 @@ hppa_hpux_sigtramp_frame_unwind_cache (s > > > Hmm, why is this chunk needed? AFAICT it shouldn't make a difference > and I have a preference for using a plain ss_wide). It's not needed, but it's a bit clearer IMO. I will revert this if you prefer. randolph -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/