From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18287 invoked by alias); 16 Nov 2005 13:05:14 -0000 Received: (qmail 18278 invoked by uid 22791); 16 Nov 2005 13:05:11 -0000 Received: from fra-del-01.spheriq.net (HELO fra-del-01.spheriq.net) (195.46.51.97) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 16 Nov 2005 13:05:10 +0000 Received: from fra-out-02.spheriq.net (fra-out-02.spheriq.net [195.46.51.130]) by fra-del-01.spheriq.net with ESMTP id jAGD4vZA030910 for ; Wed, 16 Nov 2005 13:05:00 GMT Received: from fra-cus-02.spheriq.net (fra-cus-02.spheriq.net [195.46.51.38]) by fra-out-02.spheriq.net with ESMTP id jAGD4mVI004430 for ; Wed, 16 Nov 2005 13:04:51 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-02.spheriq.net with ESMTP id jAGD4h3s002922 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Wed, 16 Nov 2005 13:04:45 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 050EFDA48; Wed, 16 Nov 2005 13:04:39 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id AC00A47391; Wed, 16 Nov 2005 13:07:37 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7097C75969; Wed, 16 Nov 2005 13:07:37 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 00E9347498; Wed, 16 Nov 2005 13:07:36 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CGZ36567 (AUTH "andrew stubbs"); Wed, 16 Nov 2005 13:04:37 GMT Message-ID: <437B2DCC.8020907@st.com> Date: Wed, 16 Nov 2005 14:56:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix 'Undefined command' error message References: <4379EC0A.3060601@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.1.07 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00227.txt.bz2 Eli Zaretskii wrote: > Why is there a need for testing *p to be non-zero? AFAIK, isalnum is > well defined for a zero argument. > > What is the reason for additional tests under TUI? > > Is this for some kind of compatibility with XDB? I do not know the answer to these questions, although I'm sure I could look into it. There are already two instances of this code in this file and each is implemented identically to the others. The reason the code is like this here is because it must replicate the tests in lookup_cmd_1 if it is to give the right message. I do not know why lookup_cmd_1 is the way it is. If you prefer I would be happy to pull out the code into a static function. Andrew