Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew STUBBS <andrew.stubbs@st.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Fix 'Undefined command' error message
Date: Tue, 15 Nov 2005 18:11:00 -0000	[thread overview]
Message-ID: <4379EC0A.3060601@st.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi,

The following demonstrates the problem:

   (gdb) abc_def
   Undefined command: "abc".  Try "help".

Non-alphanumeric characters, such as underscore, are permitted in 
command names (including user defined commands), but are not understood 
when giving error messages.

The attached patch fixes the problem.

OK?

Andrew Stubbs

[-- Attachment #2: cli-decode.patch --]
[-- Type: text/plain, Size: 844 bytes --]

2005-11-15  Andrew Stubbs  <andrew.stubbs@st.com>

	* cli-decode.c (lookup_cmd): Allow all the same characters in
	command names that lookup_cmd_composition() does.

Index: src/gdb/cli/cli-decode.c
===================================================================
--- src.orig/gdb/cli/cli-decode.c	2005-05-26 21:49:02.000000000 +0100
+++ src/gdb/cli/cli-decode.c	2005-11-09 11:39:52.000000000 +0000
@@ -1196,7 +1196,12 @@ lookup_cmd (char **line, struct cmd_list
 	    {
 	      char *p = *line, *q;
 
-	      while (isalnum (*p) || *p == '-')
+	      while (*p && (isalnum (*p) || *p == '-' || *p == '_' ||
+#if defined(TUI)
+			    (tui_active &&
+			     (*p == '+' || *p == '<' || *p == '>' || *p == '$')) ||
+#endif
+			    (xdb_commands && (*p == '!' || *p == '/' || *p == '?'))))
 		p++;
 
 	      q = (char *) alloca (p - *line + 1);

             reply	other threads:[~2005-11-15 14:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-15 18:11 Andrew STUBBS [this message]
2005-11-16  4:52 ` Eli Zaretskii
2005-11-16 14:56   ` Andrew STUBBS
2005-11-16 20:19     ` Eli Zaretskii
2005-11-16 23:28   ` Daniel Jacobowitz
2005-11-17  0:10     ` Eli Zaretskii
2005-11-22  2:17       ` Andrew STUBBS
2005-11-22  2:31         ` Andreas Schwab
2005-11-23 18:58           ` Andrew STUBBS
2005-11-23 19:19             ` Eli Zaretskii
2005-11-23 21:07               ` Andrew STUBBS
2005-11-24  4:33                 ` Daniel Jacobowitz
2005-11-24 17:29                   ` Eli Zaretskii
2005-11-24 18:11                     ` Daniel Jacobowitz
2005-11-24 20:31                       ` Eli Zaretskii
2005-11-24 22:37                         ` Andrew STUBBS
2005-11-24 23:57                           ` Eli Zaretskii
2005-11-24 10:34                 ` Eli Zaretskii
2005-11-22  5:38         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4379EC0A.3060601@st.com \
    --to=andrew.stubbs@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox