From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9627 invoked by alias); 13 Nov 2005 23:48:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9562 invoked by uid 22791); 13 Nov 2005 23:48:39 -0000 Received: from ip127.bb146.pacific.net.hk (HELO stl.com.hk) (202.64.146.127) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 13 Nov 2005 23:48:39 +0000 Received: from 241.206.17.210.dyn.pacific.net.hk ([210.17.206.241] helo=[192.168.1.10]) by stl.com.hk with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1EbRX7-0000NU-HX; Mon, 14 Nov 2005 07:45:13 +0800 Message-ID: <4377D0CB.2010304@tausq.org> Date: Mon, 14 Nov 2005 03:41:00 -0000 From: Randolph Chung User-Agent: Debian Thunderbird 1.0.2 (X11/20050331) MIME-Version: 1.0 To: Jim Blandy CC: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] Support DW_OP_breg for tracepoints References: <43775DDB.6020408@tausq.org> <8f2776cb0511131539j17ae5144n87b1aedab1fa420e@mail.gmail.com> In-Reply-To: <8f2776cb0511131539j17ae5144n87b1aedab1fa420e@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-11/txt/msg00180.txt.bz2 > Why are you adding the offset twice? Is it just cut-and-paste from > the DW_OP_fbreg code? That looks wrong, too. Yes, copy and paste. I don't understand why it's added twice either :) Dan seems to think it's ok, but I'll wait a bit before I commit anything. > This code should go in ax-gdb.[ch]. That has a translator from GDB > expressions to agent expressions; it would make sense to also have a > translator from Dwarf expressions to agent expressions. I don't feel comfortable enough with the dwarf code to touch this, so I'll have to leave this part to one of you experts :) randolph