From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3555 invoked by alias); 31 Oct 2005 19:15:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3504 invoked by uid 22791); 31 Oct 2005 19:15:35 -0000 Received: from lon-del-03.spheriq.net (HELO lon-del-03.spheriq.net) (195.46.50.99) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 31 Oct 2005 19:15:35 +0000 Received: from lon-out-01.spheriq.net ([195.46.50.129]) by lon-del-03.spheriq.net with ESMTP id j9VJFWUl011803 for ; Mon, 31 Oct 2005 19:15:32 GMT Received: from lon-cus-01.spheriq.net (lon-cus-01.spheriq.net [195.46.50.37]) by lon-out-01.spheriq.net with ESMTP id j9VJFU3U017196 for ; Mon, 31 Oct 2005 19:15:31 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by lon-cus-01.spheriq.net with ESMTP id j9VJFUWQ015449 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Mon, 31 Oct 2005 19:15:30 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id ABE3CDA42; Mon, 31 Oct 2005 19:15:29 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id 3613C475A3; Mon, 31 Oct 2005 19:18:21 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id ED58475969; Mon, 31 Oct 2005 19:18:20 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 54B9D47433; Mon, 31 Oct 2005 19:18:20 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CEX02436 (AUTH "andrew stubbs"); Mon, 31 Oct 2005 19:15:27 GMT Message-ID: <43666CDB.8010709@st.com> Date: Mon, 31 Oct 2005 20:34:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Cc: Jim Blandy , Daniel Jacobowitz Subject: Re: PATCH: Fix TUI null pointer dereference References: <4353B4A5.3010209@st.com> <435CE1E7.4040803@st.com> <435D20E0.6040504@st.com> In-Reply-To: <435D20E0.6040504@st.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.1.07 X-SW-Source: 2005-10/txt/msg00232.txt.bz2 Andrew Stubbs wrote: > Jim Blandy wrote: > >> We generally avoid using assignments directly as conditions. Just >> hoist the assignment out and just say 'if (term)'. With that change, >> feel free to commit. > > > OK. Here is an updated patch. > > I do not have write permission/ability. If I could get that set up that > would be great, but till then somebody else wil have to submit it for me > please. I have now commited this myself! Thanks to all who made it possible. Now on to the next ... Andrew