From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99626 invoked by alias); 16 Nov 2016 17:09:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99441 invoked by uid 89); 16 Nov 2016 17:09:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=re-generate, sk:ac_prog, sk:AC_PROG, ac_check_progs X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 17:09:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 436B41C13C0; Wed, 16 Nov 2016 17:09:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAGH9UUF019735; Wed, 16 Nov 2016 12:09:31 -0500 Subject: Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make To: Simon Marchi , gdb-patches@sourceware.org References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-3-simon.marchi@ericsson.com> Cc: Simon Marchi From: Pedro Alves Message-ID: <4364e654-17e0-bd63-54ea-6635f4312169@redhat.com> Date: Wed, 16 Nov 2016 17:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116160808.12830-3-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00429.txt.bz2 On 11/16/2016 04:08 PM, Simon Marchi wrote: > From: Simon Marchi > > Since GNU make is now required to build GDB, we can remove everything > that checks whether the current make implemention is the GNU one or > not. I simply removed the @GMAKE_TRUE@ prefixes and removed the whole > lines that were prefixed with @GMAKE_FALSE@. > > I removed the code in the configure scripts that set those variables. > > I also removed the following bits from the configure scripts: > > AC_CHECK_PROGS(MAKE, make): GNU make already defines a MAKE variable > internally to be used when invoking Makefiles recursively. I don't see > this variable being used anywhere else (in scripts for example), so I > think it's safe for removal. > > AC_PROG_MAKE_SET: This macro defines a SET_MAKE output variable, which > is meant to be used in Makefiles to define the MAKE variable when > using an implementation of make that doesn't already define it. > Since we are now requiring GNU make, we don't need it anymore. > Plus, I don't see SET_MAKE being used anywhere, so I don't think it > was actually doing anything... > > gdb/ChangeLog: > > * Makefile.in: Remove @GMAKE_TRUE@ prefixes and removes lines > prefixed with @GMAKE_FALSE@. Update comment related to non-GNU > make. > * configure.ac: Remove checks for the make program. > * configure: Re-generate. > > gdbserver/ChangeLog: > > * Makefile.in: Remove @GMAKE_TRUE@ prefixes and removes lines > prefixed with @GMAKE_FALSE@. Update comment related to non-GNU > make. > * configure.ac: Remove checks for the make program. > * configure: Re-generate. > > testsuite/ChangeLog: > > * Makefile.in: Remove @GMAKE_TRUE@ prefixes and removes lines > prefixed with @GMAKE_FALSE@. Update comment related to non-GNU > make. > * configure.ac: Remove checks for the make program. > * configure: Re-generate. LGTM. Thanks, Pedro Alves