Jim Blandy wrote:
> We generally avoid using assignments directly as conditions.  Just
> hoist the assignment out and just say 'if (term)'.  With that change,
> feel free to commit.

OK. Here is an updated patch.

I do not have write permission/ability. If I could get that set up that 
would be great, but till then somebody else wil have to submit it for me 
please.

Thanks

Andrew Stubbs