From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21667 invoked by alias); 24 Oct 2005 10:28:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21654 invoked by uid 22791); 24 Oct 2005 10:27:57 -0000 Received: from fra-del-04.spheriq.net (HELO fra-del-04.spheriq.net) (195.46.51.100) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 24 Oct 2005 10:27:57 +0000 Received: from fra-out-02.spheriq.net (fra-out-02.spheriq.net [195.46.51.130]) by fra-del-04.spheriq.net with ESMTP id j9OARsjl022042 for ; Mon, 24 Oct 2005 10:27:54 GMT Received: from fra-cus-01.spheriq.net (fra-cus-01.spheriq.net [195.46.51.37]) by fra-out-02.spheriq.net with ESMTP id j9OARpqj024962 for ; Mon, 24 Oct 2005 10:27:54 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-01.spheriq.net with ESMTP id j9OARn1s013159 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Mon, 24 Oct 2005 10:27:50 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id F1167DA46; Mon, 24 Oct 2005 10:27:44 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id 3008F47B67; Mon, 24 Oct 2005 10:30:33 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E8C4B75999; Mon, 24 Oct 2005 10:30:32 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7056947B63; Mon, 24 Oct 2005 10:30:32 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CDV00750 (AUTH "andrew stubbs"); Mon, 24 Oct 2005 11:27:43 +0100 (BST) Message-ID: <435CB6BC.7040101@st.com> Date: Mon, 24 Oct 2005 10:28:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Problem union comparision in TUI References: <4353BA69.1030401@st.com> <43561685.3010300@st.com> <20051019200751.GA19037@nevyn.them.org> <43576E68.8080804@st.com> <4357C346.8070400@st.com> <435900C7.2010706@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 2.3.0 X-SW-Source: 2005-10/txt/msg00186.txt.bz2 Eli Zaretskii wrote: > Why didn't you test l.loa to be LOA_ADDRESS before comparing the > addresses? In theory it must be na address if it isn't a line. If it wasn't an address then what should the code do? An assert should fix this, same as the other issues. I'll figure out how to use gdb_assert and post another patch later. Thanks Andrew