From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UTB5JOK29GlQKgkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 10:21:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lQyjpSbU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 906DD1E0BA; Fri, 01 May 2026 10:21:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FORGED_GMAIL_RCVD,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 37AA91E067 for ; Fri, 01 May 2026 10:21:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 61E4643B5511 for ; Fri, 1 May 2026 14:21:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 61E4643B5511 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=lQyjpSbU Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 9001D46A9CED for ; Fri, 1 May 2026 14:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9001D46A9CED Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9001D46A9CED Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777645257; cv=none; b=odCzBkNmImswk7pNqyFhWd9XtQnVYOEUathk3K4Def+CzEWKE8M3owYwNp+2uR4bZUoJOgdburb+0f/A4eN1H9CwvjoFQBiyMKqTy61e5id8wVhF8F20jwszyMSFcr/0fygnfyXxuWqqomoKUZbNT4QtC/9KtgkJR5+u+TLPvKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777645257; c=relaxed/simple; bh=UGHE+sosLgAyPJGkXZUK6TH427Y+RrF6vG46HSyu1Wk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=B8ouEblD9loLeRamBszJNfVwaRmQfLbkNKbe0ecnOteLS9m8Z9hiXcgwDprCRJElpceSIpMI5QTFNX3yRKFbYlRn7zN5XEVR6fg887qn7FBXFPdUpsuFg82UzpR08NJBS8wzmW+GL35OMNFnIpMc84Mm7qBwzDjG7BbH1308GRw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9001D46A9CED Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-449de065cb3so1062342f8f.2 for ; Fri, 01 May 2026 07:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777645256; x=1778250056; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=PdgdrrkZM/DyPOclVMgTWu1Oc3onpeR0Mv4SfhS0Fek=; b=lQyjpSbUIZml90u9L+gWFagpIm4pKbn+mvbkIFRggjrgAyWMJ2oqn2pO1nvKwdPK1r jqawGnzcInAW1FNKryiHyIaTLLQGbnPWu117cyg10MMhZ6MdSA47BOLnF1hb888+LmwN zNjDzB7eRvACwcBauTZgt5fCwuYagGAY5b9FxACxe45yrZKSArp5oY8Epaoh4hihgvlU NB2Bes4ZVKD8brMmLw1o17v4PzcAeNztWcQTqg7HOxCiL+L8jyQRJcSY3GyNo28hUuyT MDqUv2dg2v1I4vM8IjX5pIvVM/y+uv+xp6OqxUhAux4mBEF4owuvgNvs2hNjB+M2yRD+ 8z9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777645256; x=1778250056; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PdgdrrkZM/DyPOclVMgTWu1Oc3onpeR0Mv4SfhS0Fek=; b=pAvsnSWFypV8vY9nLUSfiQBkQkohDBqA3DYeWbO7LrgK+fFO3H1X4t3m9Wg0vz0vm7 ksUM8txig27koquCM3mK2j9sTeBzKWtdclOHpq3hUXSi+Z4Za7U/0WxqkOUQGDhaluEj XxWi2XD6HW0tVZ1BdualULmG03eaNAxh52xkyjnTO0qLz0iz6ObMv+xGpH2Jsli0yDdG C+Og29gzI/sA9PSr7zHTW0L3YcZZUYJXKBfLp460lEXMYtwmvHKsSZ9WXCdm69GTT+8e lOmO+qsBQSV4yCLJ+IXo3Owvi8Jx7he856iAutfEcgcTEt0eQ/DdNssbLfsRUJh52sb3 2QfA== X-Forwarded-Encrypted: i=1; AFNElJ+NhGf1vb3mvEtyHONUMko8bm6YR7vO4sWmrResY01ouUMezJKyAwvLT/dyAOB2tgMg3ACUmNc4Pc8xBQ==@sourceware.org X-Gm-Message-State: AOJu0YwWXvStYcHyp7XGrHddpMm6uv/GumgMIV317lGfeDggrY8U7/Tt nt8GIsBXe3Mtn2DcnVxHfIgbbwKcwaxQdLcip/L5jpJoaVP/Uqu5ABtiHkhyAQ== X-Gm-Gg: AeBDietrNaN1uSG6Lv0jdacsDxH0Uv3knvvfLTUZ5PpbbgT+Hmc/nKkFQ9LTWDbwaX9 fgcRIAU2wR607zMk0NGR1PmSFAfNGey+4lOhYVhgIIe2Tw4g2YPj4Gs3bbeOShmv8fVz0/y+N9s TIqlAUR9Wqw82DL0whYOOYenbntI61obs0HLF2Y38kvvWsNDNkf52KF/JgSzuQ+KMjWQbO1oIGN R+Nbiwlzi9HWaeCYiZ/PujmXj2HvZHTORM32E1ao+qyecAn2benp6B81eoIbf2L5dNghlRzKMXE 6cfw2zxV0CtcJ+yhvOxg9wMlsEX8evdCpLN6NeRY4PzadRUasgi7VORjTSp8w8Ge2caUKQ1p9P8 /cIgIcoz/t83t0R6yk3T8woF4IJkJ9M9yv4rKNaCJLINWFFwqshQfKmPbmm2lfkAC+epEgAlDne pBO9XjoSlG4U1fWqpcWzsveLDyaYtTrNv1BEG23PDXwD7oG8g= X-Received: by 2002:a5d:5d88:0:b0:43d:740:fb37 with SMTP id ffacd0b85a97d-4493e98281emr12312859f8f.24.1777645256256; Fri, 01 May 2026 07:20:56 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a8f51bac8sm5464102f8f.16.2026.05.01.07.20.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 07:20:55 -0700 (PDT) Message-ID: <43590e71-eacb-4461-b765-8c9d81facc85@gmail.com> Date: Fri, 1 May 2026 15:20:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable To: Simon Marchi , Luis Machado , gdb-patches@sourceware.org References: <20260501073117.2962398-1-luis.machado@amd.com> <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> Content-Language: en-US From: Luis In-Reply-To: <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 01/05/2026 15:17, Simon Marchi wrote: > On 5/1/26 3:31 AM, Luis Machado wrote: >> The str_backtrace_unavailable variable is initialized but never >> used anywhere in the codebase. >> --- >> gdb/bt-utils.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c >> index 7fc8d04f306..21a291c3df3 100644 >> --- a/gdb/bt-utils.c >> +++ b/gdb/bt-utils.c >> @@ -146,7 +146,6 @@ gdb_internal_backtrace_1 () >> #endif >> >> static const char *str_backtrace = "----- Backtrace -----\n"; >> -static const char *str_backtrace_unavailable = "Backtrace unavailable\n"; >> >> #endif /* GDB_PRINT_INTERNAL_BACKTRACE */ >> >> @@ -157,7 +156,6 @@ gdb_internal_backtrace_init_str () >> { >> #ifdef GDB_PRINT_INTERNAL_BACKTRACE >> str_backtrace = _("----- Backtrace -----\n"); >> - str_backtrace_unavailable = _("Backtrace unavailable\n"); >> #endif >> } > > Seems quite obvious to me, but I would wait for Andrew to confirm that > this wasn't meant to be used somewhere. For instance, in the > libbacktrace_error function. But I think the message there is clear, so > I'd be fine with just deleting the variable. Sorry, I just pushed this. But we can still wait for Andrew to chime in and tell us otherwise.