From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47904 invoked by alias); 28 Apr 2017 15:06:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47887 invoked by uid 89); 28 Apr 2017 15:06:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Throw X-HELO: mail-wr0-f174.google.com Received: from mail-wr0-f174.google.com (HELO mail-wr0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 15:06:25 +0000 Received: by mail-wr0-f174.google.com with SMTP id l9so35380572wre.1 for ; Fri, 28 Apr 2017 08:06:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lrCIfyQ/F1QxrBZ9t0xodnZkMpmD2HBZfvfcCMu+C0E=; b=YGmalsOpyvvglt2eeepVNg8/CYafkFcigv7SPnvVoPPG9K4TZdG1WBpMoze3gzK3lu sPKF0FiMbDtdGs3vvQHua+2WJnza74Wfya2vHKs3u3ViHpl2mblg+HQfD7g4iAvZwJjz 7ixV+GO/sVr2EX8dqu5uXIqZv1GyftKEfV8JQ3sLHcwNefSQWd1BXEIc8aZtAwYCxwd6 VhhCzlHxGFP05uVZJTUq9gjaBwrrXu0oUYAPQdo+5EsCqdZx59Wf11MhcLnxG7c6zrAB Tpr/bDSPjis+6hKI6BX6ibHGEjXnVqfqOZsHIaCkdFpNeC3df6wN9iyFwePFAIj+8VtT uwmg== X-Gm-Message-State: AN3rC/6tWNlh1SnuVb7GUfZEVCbB3KHFcWnp4iIX23goAfHQnmUHFHUH d9ceZalrhZIYK0sU0ncDsA== X-Received: by 10.223.163.80 with SMTP id d16mr9036579wrb.164.1493391985537; Fri, 28 Apr 2017 08:06:25 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id u4sm4986840wmu.0.2017.04.28.08.06.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 08:06:24 -0700 (PDT) Subject: Re: [RFA 07/10] Throw a "quit" on a KeyboardException in py-framefilter.c To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-8-tom@tromey.com> From: Phil Muldoon Message-ID: <433ecce7-2f10-24d6-b1aa-7a980019fec4@redhat.com> Date: Fri, 28 Apr 2017 15:06:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-8-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00791.txt.bz2 On 25/04/17 20:41, Tom Tromey wrote: > If a C-c comes while the Python code for a frame filter is running, it > will be turned into a Python KeyboardException. It seems good for > this to be treated like a GDB quit, so this patch changes > py-framefilter.c to notice this situation and call throw_quit in this > case. Patch LGTM (it took me awhile to understand the name_error = RuntimeError|KeyboardInterrupt and then throwing name_error. Clever!) Cheers Phil