From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Y0SaB+DCQmnJiAUAWB0awg (envelope-from ) for ; Wed, 17 Dec 2025 09:49:04 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vJb0vUQ0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+3IoUJjk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RWtzpV4X; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6L3yP4w6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0D3241E0B6; Wed, 17 Dec 2025 09:49:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 07E761E08D for ; Wed, 17 Dec 2025 09:49:03 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 776474BA2E21 for ; Wed, 17 Dec 2025 14:49:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 776474BA2E21 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vJb0vUQ0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+3IoUJjk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RWtzpV4X; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6L3yP4w6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 14C224BA2E04 for ; Wed, 17 Dec 2025 14:48:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14C224BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14C224BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765982905; cv=none; b=PhnQGWM0OXwDzzg9rEqvJzXzZA96Kc80ePQFT6iGB7hV8NS2sfKPoulcUS1l1yQXOYkmS5lZ0JAKDz8xCey7utENvk9BY9HjtjYCX44jyNNgRtfej4K8iK/CYfgVzQZJApB1aZ+yUNg+g6hbYZMFFrRH0aP39SKVeUxX5uIQzAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765982905; c=relaxed/simple; bh=qPA/5UVS6aoep1eP9N9TKWq5C2LomSx8WIG7HFcUk1Q=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=HH11by8dAQfeR2fX4tH8rWRS1h4888r0MUsj4eVrMjqjYW6m5nIPTADmVODD6TgpTLOrDhNn91xb9FYshughYLvydZX6WQLZnA1Sg+iccf8W6lcH7uaYZif9P/8J1FRyC38i3xfUOr+By96UX9axfcWCS560jrFurh2oNxq+1GY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14C224BA2E04 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD29E5BCFF; Wed, 17 Dec 2025 14:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1765982904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5gHivdZ7sDaz3YVD6nttwz/KNzk22cJUv0dqok2vM0=; b=vJb0vUQ0F8MtgOK4Ly6GjvrRJ5cg+obpEn80LyxeJJc+4CznJfP5hBh1aoggGjL11j0yn1 g9CHRRTgA5kKRbfe9IyH3jrWZ1LpIwPp7jQbc1Tw+wxV7E+uE9ErE/om5V6B+h9TSnOrwn +wNEIFgrFq4CHupB6axx5ICsrjd7r7s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1765982904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5gHivdZ7sDaz3YVD6nttwz/KNzk22cJUv0dqok2vM0=; b=+3IoUJjkitYclHqKrVr20JyP1y6fK37VxdqQZjV2fnXSWamYGtVYjIMM437ckOylZYod21 eVtEwI7XIKcBRrDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RWtzpV4X; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6L3yP4w6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1765982902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5gHivdZ7sDaz3YVD6nttwz/KNzk22cJUv0dqok2vM0=; b=RWtzpV4X6qUUpgX7vhe95g+EZEAvC55DnY9fd7AMiohVdcWX9ZIW8E84b0sdUWJ6azRGv7 eZ+BDXWrowzCAEK5S0XxcI2Y/ll1f5iiyDspF84hWpLKkLaqnAadN/m0nYgB6CdUCm/Dpi Bqx4WuU7Q1vxl/JUHPFPZx/9SXhuTgg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1765982902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5gHivdZ7sDaz3YVD6nttwz/KNzk22cJUv0dqok2vM0=; b=6L3yP4w6tSZ9xGD//+GILVS4HPBfxXbLuYRFxU8gEs1mbYUZvBTdc0NQCb9ipjRaEgWaNL p1eAQqCOQIs7LTCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BEFE63EA63; Wed, 17 Dec 2025 14:48:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fVEvLbbCQmmRHgAAD6G6ig (envelope-from ); Wed, 17 Dec 2025 14:48:22 +0000 Message-ID: <4316d420-4728-4b90-8e37-7c5429d1acbe@suse.de> Date: Wed, 17 Dec 2025 15:48:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3 1/7] gdb: improve line number lookup around inline functions To: Andrew Burgess , Tom Tromey Cc: gdb-patches@sourceware.org References: <87qzuo9e9c.fsf@tromey.com> <87ldj141ra.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87ldj141ra.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,tromey.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: DD29E5BCFF X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/17/25 3:32 PM, Andrew Burgess wrote: > Tom Tromey writes: > >>>>>>> "Andrew" == Andrew Burgess writes: >> >> Andrew> So my proposal is that the backward scan of the line table looking for >> Andrew> an is-stmt entry should not be performed when NOTCURRENT is true. In >> Andrew> the case above this means we will report the entry at index 9, which >> Andrew> is for line 10, which is correct. >> >> Thanks for the explanation. It all made sense to me. >> >> Andrew> + if ![runto foo] { >> >> We're bracing if conditions these days. >> >> Otherwise this looks good to me. >> >> Approved-By: Tom Tromey > > I fixed the TCL bracing issue and pushed just this patch for now. I'm > taking a deeper look at some of the questions you raised on the later > patches. Hi, I'm getting: ... $ pre-commit run --all-files black....................................................................Passed flake8...................................................................Passed isort....................................................................Passed codespell................................................................Passed check-include-guards.....................................................Passed check-gnu-style..........................................................Passed - hook id: check-gnu-style - duration: 0.19s check-whitespace.........................................................Passed pre-commit-setup.........................................................Passed tclint...................................................................Failed - hook id: tclint - exit code: 1 gdb/testsuite/gdb.dwarf2/dw2-inline-bt.exp:211:26: expression with substitutions should be enclosed by braces [unbraced-expr] gdb/testsuite/gdb.dwarf2/dw2-inline-bt.exp:212:26: expression with substitutions should be enclosed by braces [unbraced-expr] ... Thanks, - Tom