From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id M45sNwwGjGBZZQAAWB0awg (envelope-from ) for ; Fri, 30 Apr 2021 09:28:44 -0400 Received: by simark.ca (Postfix, from userid 112) id DB7541F11C; Fri, 30 Apr 2021 09:28:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 144931E783 for ; Fri, 30 Apr 2021 09:28:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B96FA3851C3E; Fri, 30 Apr 2021 13:28:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B96FA3851C3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619789323; bh=E6aZKDk5AoTlyCa7p9hvZTq8PK3RFHhZ3wk20uXo8fw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wBLudr54T5eQvi1ZTg3tmzwHp4bTrBu2YbOmo8Exhf7CuuoMYZ7SdjqV+z4LrCxza zVDWhOken8npO8MTSKLvunVTPj/W+aHR1LGMoqcicZcuONPc0i6U/2ta/+Imyk7bFq 3BW6HrVD9E6BeziQLQB6wU5eD8udhzmt+pL5D408= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BBBD93851C34 for ; Fri, 30 Apr 2021 13:28:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BBBD93851C34 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13UDSZDe023866 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Apr 2021 09:28:40 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13UDSZDe023866 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 934BE1E783; Fri, 30 Apr 2021 09:28:35 -0400 (EDT) Subject: Re: [committed][gdb/testsuite] Make gdb.mi/mi-sym-info.exp more robust against timeouts To: Luis Machado , Tom de Vries , gdb-patches@sourceware.org References: <20210430092743.GA24286@delia.home> <1c7ee1d2-9ff0-645c-3a0e-b6d1ed3f328f@linaro.org> <26770214-5135-391b-6bd0-4b5f39b97149@polymtl.ca> Message-ID: <42e495c3-2d64-ad20-8402-1c0b409db001@polymtl.ca> Date: Fri, 30 Apr 2021 09:28:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 30 Apr 2021 13:28:35 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-30 9:20 a.m., Luis Machado wrote:> On 4/30/21 10:06 AM, Simon Marchi wrote: >> On 2021-04-30 8:55 a.m., Luis Machado via Gdb-patches wrote: >>> Wouldn't it be more reliable to do line-by-line matching instead of sprinkling timeouts across the test? Or so I've been told. >>> >>> This doesn't seem to be an instance where GDB is taking too long, but rather that the MI output is very verbose, right? >> >> From what I can see, it's a case of GDB thinking for a long time >> (gathering symbols) before outputting anything. You can see it >> by having a >> >> $ tail -F testsuite/gdb.log >> >> on the side, while you run the test. >> >> Another one that I found times out in a similar way on my machine is >> gdb.base/info-os.exp. >> >> Simon >> > > Fair enough. But I also see the output being 113K chars in one case, no line breaks. I think these instances of very long lines are something to be dealt with. Yeah, good point. If GDB takes 6 seconds to think and Dejagnu takes 6 seconds to read the long input, the timeout is a result of the combination of both, so it wouldn't hurt to parse item by item. It's a bit more work to parse one item at the time, but in the end I think it also helps when you need to debug the test, as you can print a little something after parsing each item and know where things went wrong. Simon