From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /F6jDAfg9F+vSgAAWB0awg (envelope-from ) for ; Tue, 05 Jan 2021 16:54:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 2D3E61F0AA; Tue, 5 Jan 2021 16:54:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 870231E590 for ; Tue, 5 Jan 2021 16:54:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3EF0F3938C0C; Tue, 5 Jan 2021 21:54:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EF0F3938C0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609883654; bh=bytVM08SWx3vV6TJTjhmdk82b5XsAy2eVwppEwx5wcU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BtpEsln+zYYhWwSrYWTvE5r8x921gy4ecRwllO6k2DZDpE3yaQfKc6aY2PnKUdGIx 5Q0qxq0FdM/t4gSxAqc31kPOVlEmhFFgLbiwFCSRB3h/B1J6tbzUumwkb7gA3z7Qdq ddphXuCt1rsdwDtSfBLYT+UhyqboP1qLcpmgNoIs= Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id B8BC4385701F for ; Tue, 5 Jan 2021 21:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8BC4385701F Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 4A03D3011A3; Tue, 5 Jan 2021 16:54:11 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YLXP_-fPzk05; Tue, 5 Jan 2021 16:54:11 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 174C4300F55; Tue, 5 Jan 2021 16:54:11 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 174C4300F55 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ff9BfkIfJXmK; Tue, 5 Jan 2021 16:54:11 -0500 (EST) Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) by mail.efficios.com (Postfix) with ESMTPSA id 016E0300FA9; Tue, 5 Jan 2021 16:54:10 -0500 (EST) Subject: Re: [PATCH v2 3/3] gdb: introduce scoped debug prints To: tdevries , Simon Marchi References: <20201216204737.900975-1-simon.marchi@efficios.com> <20201216204737.900975-3-simon.marchi@efficios.com> <3ad3b11f-8a72-cd1d-a138-59c47300f147@polymtl.ca> <66ff5e72-f002-ed4f-075a-3054d17e7862@suse.de> <97ef7c08-c281-963e-96ba-0ba64a123980@polymtl.ca> <13cd76a6-9bce-706d-f98e-aa34f61cad2c@polymtl.ca> Message-ID: <42caafa7-b5b1-f828-3eaf-76e314f334ac@efficios.com> Date: Tue, 5 Jan 2021 16:54:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-05 4:26 p.m., tdevries wrote: > Yeah,=C2=A0that's=C2=A0not=C2=A0a=C2=A0bad=C2=A0idea. >=20 > The only bit that concerns me is that there's already a -prompt switch = for gdb_test_multiple, which does not add on the terminating '$', while t= his=C2=A0version=C2=A0does. >=20 > It's probably a good idea to have the -prompt switch to behave the same= in=C2=A0both=C2=A0cases. Hmm I see. Intuitively, I'd try to make gdb_test_multiple add the terminating $. Do you foresee some problems with that? The prompt passed to gdb_test_multiple only appears to be used for the various failing cases, so I don't expect that to change any passing test (I'll give it a try). Simon