From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20405 invoked by alias); 28 Jul 2005 00:18:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20315 invoked by uid 22791); 28 Jul 2005 00:18:29 -0000 Received: from mail-out4.apple.com (HELO mail-out4.apple.com) (17.254.13.23) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 28 Jul 2005 00:18:29 +0000 Received: from mailgate1.apple.com (a17-128-100-225.apple.com [17.128.100.225]) by mail-out4.apple.com (8.12.11/8.12.11) with ESMTP id j6S0IQOM016950 for ; Wed, 27 Jul 2005 17:18:26 -0700 (PDT) Received: from relay3.apple.com (relay3.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.3.17) with ESMTP id ; Wed, 27 Jul 2005 17:18:26 -0700 Received: from [17.219.199.238] ([17.219.199.238]) by relay3.apple.com (8.12.11/8.12.11) with ESMTP id j6S0INfV023323; Wed, 27 Jul 2005 17:18:24 -0700 (PDT) Message-ID: <42E8244F.9070802@apple.com> Date: Thu, 28 Jul 2005 00:18:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20040910 MIME-Version: 1.0 To: Nick Roberts CC: Mark Kettenis , drow@false.org, gdb-patches@sources.redhat.com Subject: Re: PATCH: tests for MI commands References: <17117.55351.716393.763492@farnswood.snap.net.nz> <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> <17127.29797.456624.592127@farnswood.snap.net.nz> <200507272103.j6RL3HYf022581@elgar.sibelius.xs4all.nl> <17128.2540.73355.406922@farnswood.snap.net.nz> In-Reply-To: <17128.2540.73355.406922@farnswood.snap.net.nz> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-07/txt/msg00216.txt.bz2 Nick Roberts wrote: > > Given the scarce resources for this unpaid work I ask you again to > > consider removing the mi2-*.exp files and just test the current version > > of MI. The reality is that they serve no useful purpose (mi-*.exp tests > > would still pass if GDB was invoked with "-i=mi2") and they require > > effort that could be better spent on other things. > > > > We can discuss this *after* you either: > > a) Fixed the test failures. > > > > b) Backed out your patch. > >I'd like to do a) by removing the mi2-*.exp files ;-). There doesn't seem >much point in making a load of changes if we are going to just remove the >files afterwards. > > > You promised not to do this again, and yet you did. > >Let's remember that the testsuite is there to prevent regressions in GDB and >not as an end in itself. Presumably the focus should be on having the right >tests in the suite and not just on ensuring that everything passes. > Also remember that you're not the only person working on GDB. :-) If I'm testing my patch and a bunch of MI tests start failing all of a sudden, how do I tell the difference between some terrible bug that I introduced and somebody else leaving some tests broken? It wastes everybody's time as they try to figure out whether they're at fault for the breakage. So the rule is that every change should leave the testsuite results in the same state or better, and yes, sometimes it means fixing things that you're pretty certain are going away soon. The crafty strategize this by submitting the patch to delete the unwanted tests first, then voila, the code patch just happens not to cause any visible regressions! Stan