From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32656 invoked by alias); 25 Jul 2005 14:55:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32374 invoked by uid 22791); 25 Jul 2005 14:55:33 -0000 Received: from dumbledore.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.11) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 25 Jul 2005 14:55:33 +0000 Received: (qmail 11614 invoked from network); 25 Jul 2005 14:55:31 -0000 Received: from unknown (HELO ?192.168.0.102?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Jul 2005 14:55:31 -0000 Message-ID: <42E4FD5F.80107@codesourcery.com> Date: Mon, 25 Jul 2005 14:55:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Christopher Faylor CC: gdb-patches@sources.redhat.com Subject: Re: PATCH: MinGW readline -- revised References: <200507190011.j6J0B1Ma014410@sethra.codesourcery.com> <20050724211016.GA798@nevyn.them.org> <20050725003930.GA31264@trixie.casa.cgf.cx> <20050725004109.GA17682@nevyn.them.org> <20050725145415.GD31264@trixie.casa.cgf.cx> In-Reply-To: <20050725145415.GD31264@trixie.casa.cgf.cx> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-07/txt/msg00184.txt.bz2 Christopher Faylor wrote: > On Sun, Jul 24, 2005 at 08:41:09PM -0400, Daniel Jacobowitz wrote: > >>On Sun, Jul 24, 2005 at 08:39:30PM -0400, Christopher Faylor wrote: >> >>>+ #ifdef __MINGW32__ >>>+ /* On Windows, use a special routine to read a single character >>>+ from the console. (Otherwise, no characters are available >>>+ until the user hits the return key.) */ >>>+ if (isatty (fileno (stream))) >>>+ return getch (); >>>+ #endif >> >>>This doesn't look right. Shouldn't there be an ifdef there? It's a >>>minor point but it looks like this would potentially produce dead code. >> >>I'm not quite sure what you mean - but if you're talking about the code >>after the return statement, it looks like something's gone wrong with >>the indendation in this bit. Getch is only for consoles. > > > I forgot that getch was only for consoles. Somewhow I thought it could be > used for any stdin. Silly me. Windows. So, is the patch OK? Thanks, -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304