From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32554 invoked by alias); 24 Jul 2005 22:50:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32466 invoked by uid 22791); 24 Jul 2005 22:50:25 -0000 Received: from dumbledore.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.11) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 24 Jul 2005 22:50:25 +0000 Received: (qmail 11829 invoked from network); 24 Jul 2005 22:50:23 -0000 Received: from unknown (HELO ?10.253.176.35?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jul 2005 22:50:23 -0000 Message-ID: <42E41B2B.4080103@codesourcery.com> Date: Sun, 24 Jul 2005 22:50:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com, Christopher Faylor Subject: Re: PATCH: MinGW readline -- revised References: <200507190011.j6J0B1Ma014410@sethra.codesourcery.com> <20050724211016.GA798@nevyn.them.org> In-Reply-To: <20050724211016.GA798@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-07/txt/msg00177.txt.bz2 Daniel Jacobowitz wrote: >>1) Minor bit-rot in remote-sim.c and ser-tcp.c on MinGW. In >> particular, SIGTRAP is being used unconditionally in the former, >> and the MinGW definition of "close" (in terms of "closesocket") >> needs to be a function-like macro, so as to avoid confusion in >> code like "ops->close = net_close". > > I'm not sure why you call this "bit-rot". This configuration worked in the past for me, but does not work now. Perhaps that's due to something in my environment that has changed, or use of some other patch to the source code I was testing, or a different --target setting, or something. In any case, I hereby withdraw the use of the word bit-rot! > I am inclined to go with Paul's patch for the nonce. OK; consider that hunk withrdrawn until we figure out what to do instead. > Similarly the reference to ops->close is from 2002. Independently of that, may I check in the change that fixes it? This change is entirely within MinGW-#ifdef'd code, and is purely syntactic in nature. For clarity, here is the patch: 2005-07-18 Mark Mitchell * ser-tcp.c (close): Define as a function-like macro on MinGW. Index: ser-tcp.c =================================================================== RCS file: /cvs/src/src/gdb/ser-tcp.c,v retrieving revision 1.23 diff -c -5 -p -r1.23 ser-tcp.c *** ser-tcp.c 13 Jun 2005 21:31:57 -0000 1.23 --- ser-tcp.c 24 Jul 2005 22:45:25 -0000 *************** *** 37,47 **** #include #ifdef USE_WIN32API #include #define ETIMEDOUT WSAETIMEDOUT ! #define close closesocket #define ioctl ioctlsocket #else #include #include #include --- 37,47 ---- #include #ifdef USE_WIN32API #include #define ETIMEDOUT WSAETIMEDOUT ! #define close(fd) closesocket (fd) #define ioctl ioctlsocket #else #include #include #include -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304