From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23807 invoked by alias); 11 Jun 2005 01:43:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23800 invoked by uid 22791); 11 Jun 2005 01:43:46 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 11 Jun 2005 01:43:46 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j5B1hj7Y016096 for ; Fri, 10 Jun 2005 21:43:45 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j5B1hiO07585; Fri, 10 Jun 2005 21:43:44 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j5B1hgml001883; Fri, 10 Jun 2005 21:43:42 -0400 Message-ID: <42AA41CD.1090309@redhat.com> Date: Sat, 11 Jun 2005 01:43:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird (X11/20050322) MIME-Version: 1.0 To: Mark Kettenis CC: cagney@gnu.org, gdb-patches@sources.redhat.com, drow@false.org Subject: Re: [commit] gdb_byte regcache.[hc] References: <428CC0B1.6020008@gnu.org> <20050519170724.GA24675@nevyn.them.org> <428CCBB8.4050603@gnu.org> <200506102212.j5AMCOoq028820@elgar.sibelius.xs4all.nl> In-Reply-To: <200506102212.j5AMCOoq028820@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-06/txt/msg00104.txt.bz2 Mark Kettenis wrote: > I know it's a bit late (just returned from vacation in .ca ;-), but > there is a nasty problem with the register cache stuff in this patch > :-(. Many bits of native code pass native data types to > regcache_raw_write, and this now raises a compiler warning. I'm not > sure how to solve this; adding casts all over the code is really, > really ugly, and I really, really don't want to do that. The best > thing I can come up with is that we revert the regcache_raw_xxx > interfaces back to using `void *', whereas we keep the > regcache_cooked_xxx interface as they are now (using `gdb_byte *'). I'm coming to this discussion even later than you, Mark. I've gone back thru the archive to catch up, but I'm still not clear on what is the purpose of gdb_byte (other than to avoid using bfd_byte). I thought it was to refer to target data, so we could differentiate between host bytes and target bytes. That would make sense. I'm not convinced that replacing all uses of void* makes sense.