From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-39657-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25469 invoked by alias); 26 May 2005 15:24:17 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25439 invoked by uid 22791); 26 May 2005 15:24:10 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 26 May 2005 15:24:10 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4QFO9AZ029292
	for <gdb-patches@sources.redhat.com>; Thu, 26 May 2005 11:24:09 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4QFO3O25744;
	Thu, 26 May 2005 11:24:03 -0400
Received: from [172.16.14.151] (to-dhcp51.toronto.redhat.com [172.16.14.151])
	by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j4QFO222009172;
	Thu, 26 May 2005 11:24:02 -0400
Message-ID: <4295E8AA.7000700@gnu.org>
Date: Thu, 26 May 2005 20:52:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla Thunderbird 1.0.2-1 (X11/20050323)
MIME-Version: 1.0
To: Manoj Iyer <manjo@austin.ibm.com>
CC: "M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl>,
        gdb-patches@sources.redhat.com
Subject: Re: [commit] gdb_byte part of ppc
References: <7320911886087069@webhare> <429476B0.3010506@gnu.org> <Pine.LNX.4.58.0505251001010.31147@lazy>
In-Reply-To: <Pine.LNX.4.58.0505251001010.31147@lazy>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-05/txt/msg00560.txt.bz2

Manoj Iyer wrote:
> I send out a similar patch for review yestarday and it covers a few more
> files, any comments on that one?

Oops :-(  If you look carefully through what I committed you'll notice:

  rs6000_fetch_pointer_argument (struct frame_info *frame, int argi,
  			       struct type *type)
  {
-  CORE_ADDR addr;
-  get_frame_register (frame, 3 + argi, &addr);
-  return addr;
+  return get_frame_register_unsigned (frame, 3 + argi);
  }

See the problem?  I don't seem to be able to find that change in your 
patch which puzzles me.  With the combination of gcc4, gdb_byte, and 
-Werror I couldn't miss it.

Can I suggest installing gcc4 and then using that to build gdb 
(configured with --enable-gdb-warnings=,-Werror) and look at the 
problems identified (you can override -Werror forcing a successful build 
using `cd ...build/gdb && make WERROR_CFLAGS=` )?  Warning fixes to 
*ppc* files identified doing that are fairly obvious (I keep finding the 
need to make related changes).

That leaves the s/unsigned char/gdb_byte/, that is probably also obvious 
(assuming it isn't leaving warnings behind).