From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id BC53D3851C0A for ; Tue, 19 May 2020 15:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BC53D3851C0A Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-lQO_wH7AN1OeYxaq98OI5A-1; Tue, 19 May 2020 11:43:38 -0400 X-MC-Unique: lQO_wH7AN1OeYxaq98OI5A-1 Received: by mail-wr1-f69.google.com with SMTP id n9so302wru.20 for ; Tue, 19 May 2020 08:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o0zgTTsXfteCD4XJ0/WJVWmJkLghNct4ShBPdlqVP2E=; b=o+jB/IEuXzhSl5QuU86YRJizS92Mp8umDknZpGU4bePeiudQaKs/9eaQKsmWbEn8vn bM2xgG4wiXOHDhXlPlPtjTgM8SyYv1d8lbNf9thGTfAhDiMcbcI0pwgTKjziv6dEQcfl Zf96Fd1RyBUOYzNJbeFE9gcRlYEOGp1Okrv3UGKnJfREznc3zKGRW1aE888+UWnBwIF7 nrdVFpQ9QUMXzx3HbhmV07o0NOG6nIc1BebtbPqAuLGT4HVczHsh/R4/TF4/etOZ3hB3 YHGZEClEuucPh4BMFcllLr7tiliXZUoibCyMJmYnfTAdmG74TPF7ejcf+IiIIU5rLKF5 RPzg== X-Gm-Message-State: AOAM532A3f/BWLiB+dKH/UG4JFYZrYFQLyZhRleczbUQ26OeIfawWWOK bg+vcjeRSjVuDUTlzOt3lCfMQllFK14wfp1oQS+STXmfVXqCIi7V0wsc4YG/7yC2yH08epm1l2c 475ftNhm1rVysk4RU+LyQ3Q== X-Received: by 2002:adf:ed8d:: with SMTP id c13mr26846104wro.154.1589903016449; Tue, 19 May 2020 08:43:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGGeqQUCgb0dVeahaz+1sIwXVq8AnRVoUNJBSD9j+i+hlTlehXFCsQ6MVQxi61FkYCDq/9gA== X-Received: by 2002:adf:ed8d:: with SMTP id c13mr26846075wro.154.1589903016075; Tue, 19 May 2020 08:43:36 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id n128sm55572wmb.47.2020.05.19.08.43.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 08:43:35 -0700 (PDT) Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> <1925ad2ac77a84fa40389ad801e42a8241ab8b13.camel@skynet.be> From: Pedro Alves Message-ID: <4292edef-cb6a-739c-dc43-cfb15778cc2a@redhat.com> Date: Tue, 19 May 2020 16:43:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1925ad2ac77a84fa40389ad801e42a8241ab8b13.camel@skynet.be> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 15:43:44 -0000 On 5/18/20 3:21 PM, Philippe Waroquiers wrote: > > Patch looks nice to me. > > Just one small comment: the call > add_setshow_enum_cmd ("exec-file-mismatch", class_support, > still references exec-file name in the help doc string. > The help doc should better reference the build ID, or alternatively > be generic by removing "name". Thanks, completely forgot checking that! I went with the removing "name" approach. I've applied this locally: @@ -1250,8 +1250,8 @@ Set exec-file-mismatch handling (ask|warn|off)."), _("\ Show exec-file-mismatch handling (ask|warn|off)."), _("\ -Specifies how to handle a mismatch between the current exec-file name\n\ -loaded by GDB and the exec-file name automatically determined when attaching\n\ +Specifies how to handle a mismatch between the current exec-file\n\ +loaded by GDB and the exec-file automatically determined when attaching\n\ to a process:\n\n\ ask - warn the user and ask whether to load the determined exec-file.\n\ warn - warn the user, but do not change the exec-file.\n\